mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Vet and Lint the entire system (#296)

Browse Source 
* govet and golint corrections
This commit is contained in:
Tom Limoncelli
2018-01-09 12:53:16 -05:00
committed by GitHub
parent 1a91a7f536
commit b7c251190f
64 changed files with 540 additions and 433 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
providers/dnsimple/dnsimpleProvider.go
View File

@@ -40,16 +40,19 @@ var defaultNameServerNames = []string{
"ns4.dnsimple.com",
}
// DnsimpleApi is the handle for this provider.
type DnsimpleApi struct {
AccountToken string // The account access token
BaseURL string // An alternate base URI
accountId string // Account id cache
accountID string // Account id cache
}
// GetNameservers returns the name servers for a domain.
func (c *DnsimpleApi) GetNameservers(domainName string) ([]*models.Nameserver, error) {
return models.StringsToNameservers(defaultNameServerNames), nil
}
// GetDomainCorrections returns corrections that update a domain.
func (c *DnsimpleApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
corrections := []*models.Correction{}
dc.Punycode()
@@ -129,6 +132,7 @@ func (c *DnsimpleApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.C
return corrections, nil
}
// GetRegistrarCorrections returns corrections that update a domain's registrar.
func (c *DnsimpleApi) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
corrections := []*models.Correction{}
@@ -168,8 +172,8 @@ func (c *DnsimpleApi) getClient() *dnsimpleapi.Client {
return client
}
func (c *DnsimpleApi) getAccountId() (string, error) {
if c.accountId == "" {
func (c *DnsimpleApi) getAccountID() (string, error) {
if c.accountID == "" {
client := c.getClient()
whoamiResponse, err := client.Identity.Whoami()
if err != nil {
@@ -178,15 +182,15 @@ func (c *DnsimpleApi) getAccountId() (string, error) {
if whoamiResponse.Data.User != nil && whoamiResponse.Data.Account == nil {
return "", fmt.Errorf("DNSimple token appears to be a user token. Please supply an account token")
}
c.accountId = strconv.Itoa(whoamiResponse.Data.Account.ID)
c.accountID = strconv.Itoa(whoamiResponse.Data.Account.ID)
}
return c.accountId, nil
return c.accountID, nil
}
func (c *DnsimpleApi) getRecords(domainName string) ([]dnsimpleapi.ZoneRecord, error) {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return nil, err
}
@@ -195,7 +199,7 @@ func (c *DnsimpleApi) getRecords(domainName string) ([]dnsimpleapi.ZoneRecord, e
recs := []dnsimpleapi.ZoneRecord{}
opts.Page = 1
for {
recordsResponse, err := client.Zones.ListRecords(accountId, domainName, opts)
recordsResponse, err := client.Zones.ListRecords(accountID, domainName, opts)
if err != nil {
return nil, err
}
@@ -216,27 +220,26 @@ func (c *DnsimpleApi) getRecords(domainName string) ([]dnsimpleapi.ZoneRecord, e
func (c *DnsimpleApi) getNameservers(domainName string) ([]string, error) {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return nil, err
}
domainResponse, err := client.Domains.GetDomain(accountId, domainName)
domainResponse, err := client.Domains.GetDomain(accountID, domainName)
if err != nil {
return nil, err
}
if domainResponse.Data.State == stateRegistered {
delegationResponse, err := client.Registrar.GetDomainDelegation(accountId, domainName)
delegationResponse, err := client.Registrar.GetDomainDelegation(accountID, domainName)
if err != nil {
return nil, err
}
return *delegationResponse.Data, nil
} else {
return defaultNameServerNames, nil
}
return defaultNameServerNames, nil
}
// Returns a function that can be invoked to change the delegation of the domain to the given name server names.
@@ -244,14 +247,14 @@ func (c *DnsimpleApi) updateNameserversFunc(nameServerNames []string, domainName
return func() error {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return err
}
nameServers := dnsimpleapi.Delegation(nameServerNames)
_, err = client.Registrar.ChangeDomainDelegation(accountId, domainName, &nameServers)
_, err = client.Registrar.ChangeDomainDelegation(accountID, domainName, &nameServers)
if err != nil {
return err
}
@@ -265,7 +268,7 @@ func (c *DnsimpleApi) createRecordFunc(rc *models.RecordConfig, domainName strin
return func() error {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return err
}
@@ -276,7 +279,7 @@ func (c *DnsimpleApi) createRecordFunc(rc *models.RecordConfig, domainName strin
TTL: int(rc.TTL),
Priority: int(rc.MxPreference),
}
_, err = client.Zones.CreateRecord(accountId, domainName, record)
_, err = client.Zones.CreateRecord(accountID, domainName, record)
if err != nil {
return err
}
@@ -286,16 +289,16 @@ func (c *DnsimpleApi) createRecordFunc(rc *models.RecordConfig, domainName strin
}
// Returns a function that can be invoked to delete a record in a zone.
func (c *DnsimpleApi) deleteRecordFunc(recordId int, domainName string) func() error {
func (c *DnsimpleApi) deleteRecordFunc(recordID int, domainName string) func() error {
return func() error {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return err
}
_, err = client.Zones.DeleteRecord(accountId, domainName, recordId)
_, err = client.Zones.DeleteRecord(accountID, domainName, recordID)
if err != nil {
return err
}
@@ -310,7 +313,7 @@ func (c *DnsimpleApi) updateRecordFunc(old *dnsimpleapi.ZoneRecord, rc *models.R
return func() error {
client := c.getClient()
accountId, err := c.getAccountId()
accountID, err := c.getAccountID()
if err != nil {
return err
}
@@ -323,7 +326,7 @@ func (c *DnsimpleApi) updateRecordFunc(old *dnsimpleapi.ZoneRecord, rc *models.R
Priority: int(rc.MxPreference),
}
_, err = client.Zones.UpdateRecord(accountId, domainName, old.ID, record)
_, err = client.Zones.UpdateRecord(accountID, domainName, old.ID, record)
if err != nil {
return err
}
@@ -346,7 +349,7 @@ func newProvider(m map[string]string, metadata json.RawMessage) (*DnsimpleApi, e
api := &DnsimpleApi{}
api.AccountToken = m["token"]
if api.AccountToken == "" {
return nil, fmt.Errorf("DNSimple token must be provided.")
return nil, fmt.Errorf("missing DNSimple token")
}
if m["baseurl"] != "" {