From bded57b375730dc3996ccaff35d6ca4adab657ca Mon Sep 17 00:00:00 2001 From: Amelia Aronsohn Date: Thu, 30 Mar 2023 10:19:34 -0700 Subject: [PATCH] DNSimple: Remove CAA Whitespace in Target restriction (#2250) Signed-off-by: Amelia Aronsohn --- documentation/providers/dnsimple.md | 14 +------------- providers/dnsimple/auditrecords.go | 13 +++++-------- 2 files changed, 6 insertions(+), 21 deletions(-) diff --git a/documentation/providers/dnsimple.md b/documentation/providers/dnsimple.md index f3182c26e..8c5af791f 100644 --- a/documentation/providers/dnsimple.md +++ b/documentation/providers/dnsimple.md @@ -45,16 +45,4 @@ DNSControl depends on a DNSimple account access token. ## Caveats -### CAA - -As of July 2022, the DNSimple DNS does not accept spaces in CAA records. Putting spaces in the record will result in a 400 Validation Failed error. - -```text -0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" -``` - -Removing the spaces will work. -```text -0 issue "letsencrypt.org;validationmethods=dns-01;accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" -``` - +None at this time diff --git a/providers/dnsimple/auditrecords.go b/providers/dnsimple/auditrecords.go index 2e257430b..966241cad 100644 --- a/providers/dnsimple/auditrecords.go +++ b/providers/dnsimple/auditrecords.go @@ -11,18 +11,15 @@ import ( func AuditRecords(records []*models.RecordConfig) []error { a := rejectif.Auditor{} - a.Add("CAA", rejectif.CaaTargetContainsWhitespace) // Last verified xxxx-xx-xx + a.Add("MX", rejectif.MxNull) // Last verified 2023-03 - a.Add("MX", rejectif.MxNull) // Last verified 2020-12-28 + a.Add("TXT", rejectif.TxtHasMultipleSegments) // Last verified 2023-03 - a.Add("TXT", rejectif.TxtHasMultipleSegments) // Last verified 2022-07 - //TODO(onlyhavecans) I think we can support multiple strings. + a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2023-03 - a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2022-07 + a.Add("TXT", rejectif.TxtHasUnpairedDoubleQuotes) // Last verified 2023-03 - a.Add("TXT", rejectif.TxtHasUnpairedDoubleQuotes) // Last verified 2022-07 - - a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2022-07 + a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2023-03 return a.Audit(records) }