mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Bugfix: redirect: should be redirect= (#507)

Browse Source
This commit is contained in:
Tom Limoncelli
2019-06-21 07:48:59 -04:00
committed by GitHub
parent 98232b0933
commit be10c5f7c2
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/spflib/parse.go
View File

@@ -69,14 +69,19 @@ func Parse(text string, dnsres Resolver) (*SPFRecord, error) {
} else if strings.HasPrefix(part, "ip4:") || strings.HasPrefix(part, "ip6:") {
// ip address, 0 lookups
continue
} else if strings.HasPrefix(part, "include:") || strings.HasPrefix(part, "redirect:") {
if strings.HasPrefix(part, "redirect:") {
} else if strings.HasPrefix(part, "include:") || strings.HasPrefix(part, "redirect=") {
// redirect is only partially implemented. redirect is a
// complex and IMHO ambiguously defined feature. We only
// implement the most simple edge case: when it is the last item
// in the string. In that situation, it is the equivalent of
// include:.
if strings.HasPrefix(part, "redirect=") {
// pi + 2: because pi starts at 0 when it iterates starting on parts[1],
// and because len(parts) is one bigger than the highest index.
if (pi + 2) != len(parts) {
return nil, errors.Errorf("%s must be last item", part)
}
p.IncludeDomain = strings.TrimPrefix(part, "redirect:")
p.IncludeDomain = strings.TrimPrefix(part, "redirect=")
} else {
p.IncludeDomain = strings.TrimPrefix(part, "include:")
}