mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Bugfix: redirect: should be redirect= (#507)

Browse Source
This commit is contained in:
Tom Limoncelli
2019-06-21 07:48:59 -04:00
committed by GitHub
parent 98232b0933
commit be10c5f7c2
3 changed files with 39 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
pkg/spflib/parse_test.go
View File

@ -42,19 +42,46 @@ func TestParseWithDoubleSpaces(t *testing.T) {
}
func TestParseRedirectNotLast(t *testing.T) {
// Make sure redirect:foo fails if it isn't the last item.
// Make sure redirect=foo fails if it isn't the last item.
dnsres, err := NewCache("testdata-dns1.json")
if err != nil {
t.Fatal(err)
}
_, err = Parse(strings.Join([]string{"v=spf1",
"redirect=servers.mcsv.net",
"~all"}, " "), dnsres)
if err == nil {
t.Fatal("should fail")
}
}
func TestParseRedirectColon(t *testing.T) {
// Make sure redirect:foo fails.
dnsres, err := NewCache("testdata-dns1.json")
if err != nil {
t.Fatal(err)
}
_, err = Parse(strings.Join([]string{"v=spf1",
"redirect:servers.mcsv.net",
"~all"}, " "), dnsres)
}, " "), dnsres)
if err == nil {
t.Fatal("should fail")
}
}
func TestParseRedirectOnly(t *testing.T) {
dnsres, err := NewCache("testdata-dns1.json")
if err != nil {
t.Fatal(err)
}
rec, err := Parse(strings.Join([]string{"v=spf1",
"redirect=servers.mcsv.net"}, " "), dnsres)
if err != nil {
t.Fatal(err)
}
t.Log(rec.Print())
}
func TestParseRedirectLast(t *testing.T) {
dnsres, err := NewCache("testdata-dns1.json")
if err != nil {
@ -62,7 +89,7 @@ func TestParseRedirectLast(t *testing.T) {
}
rec, err := Parse(strings.Join([]string{"v=spf1",
"ip4:198.252.206.0/24",
"redirect:servers.mcsv.net"}, " "), dnsres)
"redirect=servers.mcsv.net"}, " "), dnsres)
if err != nil {
t.Fatal(err)
}