mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Create non-existing zones while push or print warning while preview (#1528)

Browse Source 
* Create non-existing zones while push. While preview print a warning

Signed-off-by: Jan-Philipp Benecke <jan-philipp.benecke@jpbe.de>

* Ooops, remove testing lines

Signed-off-by: Jan-Philipp Benecke <jan-philipp.benecke@jpbe.de>

* Renaming flag

Signed-off-by: Jan-Philipp Benecke <jan-philipp.benecke@jpbe.de>

* Change flag description

Signed-off-by: Jan-Philipp Benecke <jan-philipp.benecke@jpbe.de>

* Reverse flag logic

Signed-off-by: Jan-Philipp Benecke <jan-philipp@bnck.me>
This commit is contained in:
Jan-Philipp Benecke
2022-06-08 20:53:16 +02:00
committed by GitHub
parent 1f641c0f58
commit c0450223c2
4 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
commands/previewPush.go
View File

@ -15,6 +15,8 @@ import (
"github.com/StackExchange/dnscontrol/v3/pkg/notifications"
"github.com/StackExchange/dnscontrol/v3/pkg/printer"
"github.com/StackExchange/dnscontrol/v3/providers"
"golang.org/x/exp/slices"
)
var _ = cmd(catMain, func() *cli.Command {
@ -36,6 +38,7 @@ type PreviewArgs struct {
FilterArgs
Notify bool
WarnChanges bool
NoPopulate bool
}
func (args *PreviewArgs) flags() []cli.Flag {
@ -52,6 +55,11 @@ func (args *PreviewArgs) flags() []cli.Flag {
Destination: &args.WarnChanges,
Usage: `set to true for non-zero return code if there are changes`,
})
flags = append(flags, &cli.BoolFlag{
Name: "no-populate",
Destination: &args.NoPopulate,
Usage: `Use this flag to not auto-create non-existing zones at the provider`,
})
return flags
}
@ -128,6 +136,27 @@ DomainLoop:
domain.Nameservers = nsList
nameservers.AddNSRecords(domain)
for _, provider := range domain.DNSProviderInstances {
if !args.NoPopulate {
// preview run: check if zone is already there, if not print a warning
if lister, ok := provider.Driver.(providers.ZoneLister); ok && !push {
zones, err := lister.ListZones()
if err != nil {
return err
}
if !slices.Contains(zones, domain.Name) {
out.Warnf("Domain '%s' does not exist in the '%s' profile and will be added automatically.\n", domain.Name, provider.Name)
continue // continue with next provider, as we can not determine corrections without an existing zone
}
} else if creator, ok := provider.Driver.(providers.DomainCreator); ok && push {
// this is the actual push, ensure domain exists at DSP
if err := creator.EnsureDomainExists(domain.Name); err != nil {
out.Warnf("Error creating domain: %s\n", err)
continue // continue with next provider, as we couldn't create this one
}
}
}
dc, err := domain.Copy()
if err != nil {
return err