From c899706309b8b3e8d016fd384b4a882f59b275a8 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Mon, 12 Oct 2020 12:55:10 -0400 Subject: [PATCH] Fix version --- docs/release-engineering.md | 8 ++++---- pkg/version/version.go | 7 ++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/docs/release-engineering.md b/docs/release-engineering.md index d5127b915..f3f223733 100644 --- a/docs/release-engineering.md +++ b/docs/release-engineering.md @@ -32,11 +32,11 @@ go version Edit the "Version" variable in `pkg/version/version.go` and commit. ``` -export PREVVERSION=3.3.0 <<< Change to the previous version -export VERSION=3.4.0 <<< Change to the new release version +export PREVVERSION=3.3.0 <<< Change to the previous version +export VERSION=3.4.0 <<< Change to the new release version git checkout master -vi pkg/version/version.go <<< Change "Version" to new release version -git commit -m'Release v'"$VERSION" pkg/version/version.go +vi main.go <<< Change "Version" to new release version +git commit -m'Release v'"$VERSION" main.go git tag v"$VERSION" git push origin tag v"$VERSION" ``` diff --git a/pkg/version/version.go b/pkg/version/version.go index b0c33ed6a..c2a692984 100644 --- a/pkg/version/version.go +++ b/pkg/version/version.go @@ -7,13 +7,10 @@ import ( "time" ) -// Version management. Goals: -// 1. Someone who just does "go get" has at least some information. -// 2. If built with build/build.go, more specific build information gets put in. -// Update the number here manually each release, so at least we have a range for go-get people. +// NOTE: main() updates these. var ( SHA = "" - Version = "3.4.0" + Version = "" BuildTime = "" )