mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

CHORE: Linting (#1704)

Browse Source 
* Remove deprecated io/ioutil
* fixup!
* staticcheck and linting
* revert models/provider.go
* Fix imports to new style
* linting
This commit is contained in:
Tom Limoncelli
2022-08-14 20:46:56 -04:00
committed by GitHub
parent e1b6b163d7
commit ccb582b278
73 changed files with 130 additions and 176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
providers/autodns/api.go
View File

@@ -25,7 +25,7 @@ type ZoneListRequest struct {
Filter []*ZoneListFilter `json:"filters"`
}
func (api *autoDnsProvider) request(method string, requestPath string, data interface{}) ([]byte, error) {
func (api *autoDNSProvider) request(method string, requestPath string, data interface{}) ([]byte, error) {
client := &http.Client{}
requestURL := api.baseURL
@@ -57,7 +57,7 @@ func (api *autoDnsProvider) request(method string, requestPath string, data inte
return responseText, nil
}
func (api *autoDnsProvider) findZoneSystemNameServer(domain string) (*models.Nameserver, error) {
func (api *autoDNSProvider) findZoneSystemNameServer(domain string) (*models.Nameserver, error) {
request := &ZoneListRequest{}
request.Filter = append(request.Filter, &ZoneListFilter{
@@ -82,7 +82,7 @@ func (api *autoDnsProvider) findZoneSystemNameServer(domain string) (*models.Nam
return systemNameServer, nil
}
func (api *autoDnsProvider) getZone(domain string) (*Zone, error) {
func (api *autoDNSProvider) getZone(domain string) (*Zone, error) {
systemNameServer, err := api.findZoneSystemNameServer(domain)
if err != nil {
return nil, err
@@ -100,7 +100,7 @@ func (api *autoDnsProvider) getZone(domain string) (*Zone, error) {
return responseObject.Data[0], nil
}
func (api *autoDnsProvider) updateZone(domain string, resourceRecords []*ResourceRecord, nameServers []*models.Nameserver, zoneTTL uint32) error {
func (api *autoDNSProvider) updateZone(domain string, resourceRecords []*ResourceRecord, nameServers []*models.Nameserver, zoneTTL uint32) error {
systemNameServer, err := api.findZoneSystemNameServer(domain)
if err != nil {

14
providers/autodns/autoDnsProvider.go
View File

@@ -3,7 +3,6 @@ package autodns
import (
"encoding/json"
"fmt"
"github.com/StackExchange/dnscontrol/v3/pkg/printer"
"net/http"
"net/url"
"regexp"
@@ -12,6 +11,7 @@ import (
"github.com/StackExchange/dnscontrol/v3/models"
"github.com/StackExchange/dnscontrol/v3/pkg/diff"
"github.com/StackExchange/dnscontrol/v3/pkg/printer"
"github.com/StackExchange/dnscontrol/v3/pkg/txtutil"
"github.com/StackExchange/dnscontrol/v3/providers"
)
@@ -30,7 +30,7 @@ var features = providers.DocumentationNotes{
providers.CanUseTLSA: providers.Cannot(),
}
type autoDnsProvider struct {
type autoDNSProvider struct {
baseURL url.URL
defaultHeaders http.Header
}
@@ -45,7 +45,7 @@ func init() {
// New creates a new API handle.
func New(settings map[string]string, _ json.RawMessage) (providers.DNSServiceProvider, error) {
api := &autoDnsProvider{}
api := &autoDNSProvider{}
api.baseURL = url.URL{
Scheme: "https",
@@ -67,7 +67,7 @@ func New(settings map[string]string, _ json.RawMessage) (providers.DNSServicePro
}
// GetDomainCorrections returns the corrections for a domain.
func (api *autoDnsProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
func (api *autoDNSProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
var changes []*models.RecordConfig
dc, err := dc.Copy()
@@ -169,7 +169,7 @@ func (api *autoDnsProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*mo
err := api.updateZone(domain, resourceRecords, nameServers, zoneTTL)
if err != nil {
fmt.Errorf(err.Error())
return fmt.Errorf(err.Error())
}
return nil
@@ -181,7 +181,7 @@ func (api *autoDnsProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*mo
}
// GetNameservers returns the nameservers for a domain.
func (api *autoDnsProvider) GetNameservers(domain string) ([]*models.Nameserver, error) {
func (api *autoDNSProvider) GetNameservers(domain string) ([]*models.Nameserver, error) {
zone, err := api.getZone(domain)
if err != nil {
@@ -192,7 +192,7 @@ func (api *autoDnsProvider) GetNameservers(domain string) ([]*models.Nameserver,
}
// GetZoneRecords gets the records of a zone and returns them in RecordConfig format.
func (api *autoDnsProvider) GetZoneRecords(domain string) (models.Records, error) {
func (api *autoDNSProvider) GetZoneRecords(domain string) (models.Records, error) {
zone, _ := api.getZone(domain)
existingRecords := make([]*models.RecordConfig, len(zone.ResourceRecords))
for i, resourceRecord := range zone.ResourceRecords {

4
providers/autodns/types.go
View File

@@ -5,6 +5,7 @@ import (
"github.com/StackExchange/dnscontrol/v3/providers/bind"
)
// ResourceRecord represents DNS records in API calls.
type ResourceRecord struct {
// The name of the record.
@@ -29,6 +30,7 @@ type ResourceRecord struct {
Value string `json:"value,omitempty"`
}
// MainAddressRecord represents an address record in API calls.
type MainAddressRecord struct {
// TTL of the record (Optionally if not set then Default SOA TTL is used)
@@ -38,6 +40,7 @@ type MainAddressRecord struct {
Value string `json:"address,omitempty"`
}
// Zone represents the Zone in API calls.
type Zone struct {
Origin string `json:"origin"`
@@ -60,6 +63,7 @@ type Zone struct {
SystemNameServer string `json:"virtualNameServer,omitempty"`
}
// JSONResponseDataZone represents the response to the DataZone call.
type JSONResponseDataZone struct {
// The data for the response. The type of the objects are depending on the request and are also specified in the responseObject value of the response.