From d1fba2c236573a3b71b32f2de2c14b78e2dbdbc0 Mon Sep 17 00:00:00 2001 From: Norm MacLennan Date: Fri, 14 Jul 2017 16:03:04 -0400 Subject: [PATCH] Route53 provider: pass the right correction message based on action (#151) --- providers/route53/route53Provider.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/providers/route53/route53Provider.go b/providers/route53/route53Provider.go index 4992ce89b..c20c042ff 100644 --- a/providers/route53/route53Provider.go +++ b/providers/route53/route53Provider.go @@ -224,14 +224,15 @@ func (r *route53Provider) GetDomainCorrections(dc *models.DomainConfig) ([]*mode changeReq := &r53.ChangeResourceRecordSetsInput{ ChangeBatch: &r53.ChangeBatch{Changes: changes}, } + delReq := &r53.ChangeResourceRecordSetsInput{ ChangeBatch: &r53.ChangeBatch{Changes: dels}, } - addCorrection := func(req *r53.ChangeResourceRecordSetsInput) { + addCorrection := func(msg string, req *r53.ChangeResourceRecordSetsInput) { corrections = append(corrections, &models.Correction{ - Msg: changeDesc, + Msg: msg, F: func() error { req.HostedZoneId = zone.Id _, err := r.client.ChangeResourceRecordSets(req) @@ -239,11 +240,13 @@ func (r *route53Provider) GetDomainCorrections(dc *models.DomainConfig) ([]*mode }, }) } + if len(dels) > 0 { - addCorrection(delReq) + addCorrection(delDesc, delReq) } + if len(changes) > 0 { - addCorrection(changeReq) + addCorrection(changeDesc, changeReq) } return corrections, nil