From d2625cf17ad41099e1e4a4c03b9c5477775a076b Mon Sep 17 00:00:00 2001 From: Vatsalya Goel Date: Sat, 8 Feb 2020 06:25:08 +1100 Subject: [PATCH] Using Alias Records breaks DNSControl (#616) --- providers/azuredns/azureDnsProvider.go | 28 +++++++++++++++----------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/providers/azuredns/azureDnsProvider.go b/providers/azuredns/azureDnsProvider.go index 10f43b4d1..3b999daf3 100644 --- a/providers/azuredns/azureDnsProvider.go +++ b/providers/azuredns/azureDnsProvider.go @@ -266,20 +266,24 @@ func nativeToRecords(set *adns.RecordSet, origin string) []*models.RecordConfig var results []*models.RecordConfig switch rtype := *set.Type; rtype { case "Microsoft.Network/dnszones/A": - for _, rec := range *set.ARecords { - rc := &models.RecordConfig{TTL: uint32(*set.TTL)} - rc.SetLabelFromFQDN(*set.Fqdn, origin) - rc.Type = "A" - _ = rc.SetTarget(*rec.Ipv4Address) - results = append(results, rc) + if *set.ARecords != nil { + for _, rec := range *set.ARecords { + rc := &models.RecordConfig{TTL: uint32(*set.TTL)} + rc.SetLabelFromFQDN(*set.Fqdn, origin) + rc.Type = "A" + _ = rc.SetTarget(*rec.Ipv4Address) + results = append(results, rc) + } } case "Microsoft.Network/dnszones/AAAA": - for _, rec := range *set.AaaaRecords { - rc := &models.RecordConfig{TTL: uint32(*set.TTL)} - rc.SetLabelFromFQDN(*set.Fqdn, origin) - rc.Type = "AAAA" - _ = rc.SetTarget(*rec.Ipv6Address) - results = append(results, rc) + if *set.AaaaRecords != nil { + for _, rec := range *set.AaaaRecords { + rc := &models.RecordConfig{TTL: uint32(*set.TTL)} + rc.SetLabelFromFQDN(*set.Fqdn, origin) + rc.Type = "AAAA" + _ = rc.SetTarget(*rec.Ipv6Address) + results = append(results, rc) + } } case "Microsoft.Network/dnszones/CNAME": rc := &models.RecordConfig{TTL: uint32(*set.TTL)}