mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Add --expect-no-changes flag to preview (#449)

Browse Source 
We want to offer a return-code oriented interface to detect changes
pending to be applied. The preview command, by default, returns 0
regardless of pending changes.

We add a flag, `--expect-no-changes`, that will return non-zero if
there are changes pending application, and 0 if there are none.
This commit is contained in:
Miguel Bernabeu Diaz
2019-02-14 02:11:26 +01:00
committed by Craig Peterson
parent f6b26f24c6
commit d4947fce23
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
commands/previewPush.go
View File

@ -34,6 +34,7 @@ type PreviewArgs struct {
GetCredentialsArgs GetCredentialsArgs
FilterArgs FilterArgs
Notify bool Notify bool
WarnChanges bool
} }
func (args *PreviewArgs) flags() []cli.Flag { func (args *PreviewArgs) flags() []cli.Flag {
@ -45,6 +46,11 @@ func (args *PreviewArgs) flags() []cli.Flag {
Destination: &args.Notify, Destination: &args.Notify,
Usage: `set to true to send notifications to configured destinations`, Usage: `set to true to send notifications to configured destinations`,
}) })
flags = append(flags, cli.BoolFlag{
Name: "expect-no-changes",
Destination: &args.WarnChanges,
Usage: `set to true for non-zero return code if there are changes`,
})
return flags return flags
} }
@ -165,6 +171,9 @@ DomainLoop:
if anyErrors { if anyErrors {
return errors.Errorf("Completed with errors") return errors.Errorf("Completed with errors")
} }
if totalCorrections != 0 && args.WarnChanges {
return errors.Errorf("There are pending changes")
}
return nil return nil
} }