mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Documentation: Customizing nameservers for hosting.de provider (#1396)

Browse Source 
* Add support for default nameservers

Uses provider metadata with default_ns key.

Fixes #1401.

* Fix formatting

* Add documentation on custom nameservers

* Rework hosting.de documentation

Separate usage with hosting.de and usage with compatible providers.

Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>
This commit is contained in:
Julius Rickert
2022-02-22 16:54:02 +01:00
committed by GitHub
parent 45e8622c0a
commit d5665ceaf6
3 changed files with 53 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
providers/hostingde/api.go
View File

@@ -17,6 +17,7 @@ type hostingdeProvider struct {
authToken string
ownerAccountID string
baseURL string
nameservers []string
}
func (hp *hostingdeProvider) getDomainConfig(domain string) (*domainConfig, error) {
@@ -51,7 +52,7 @@ func (hp *hostingdeProvider) createZone(domain string) error {
}
records := []*record{}
for _, ns := range defaultNameservers {
for _, ns := range hp.nameservers {
records = append(records, &record{
Name: domain,
Type: "NS",

40
providers/hostingde/hostingdeProvider.go
View File

@@ -11,7 +11,7 @@ import (
"github.com/StackExchange/dnscontrol/v3/providers"
)
var defaultNameservers = []string{"ns1.hosting.de", "ns2.hosting.de", "ns3.hosting.de"}
var defaultNameservers = []string{"ns1.hosting.de.", "ns2.hosting.de.", "ns3.hosting.de."}
var features = providers.DocumentationNotes{
providers.CanAutoDNSSEC: providers.Unimplemented("Supported but not implemented yet."),
@@ -40,7 +40,11 @@ func init() {
providers.RegisterDomainServiceProviderType("HOSTINGDE", fns, features)
}
func newHostingde(m map[string]string) (*hostingdeProvider, error) {
type providerMeta struct {
DefaultNS []string `json:"default_ns"`
}
func newHostingde(m map[string]string, providermeta json.RawMessage) (*hostingdeProvider, error) {
authToken, ownerAccountID, baseURL := m["authToken"], m["ownerAccountId"], m["baseURL"]
if authToken == "" {
@@ -56,33 +60,33 @@ func newHostingde(m map[string]string) (*hostingdeProvider, error) {
authToken: authToken,
ownerAccountID: ownerAccountID,
baseURL: baseURL,
nameservers: defaultNameservers,
}
if len(providermeta) > 0 {
var pm providerMeta
if err := json.Unmarshal(providermeta, &pm); err != nil {
return nil, fmt.Errorf("hosting.de: could not parse providermeta: %w", err)
}
if len(pm.DefaultNS) > 0 {
hp.nameservers = pm.DefaultNS
}
}
return hp, nil
}
func newHostingdeDsp(m map[string]string, raw json.RawMessage) (providers.DNSServiceProvider, error) {
return newHostingde(m)
func newHostingdeDsp(m map[string]string, providermeta json.RawMessage) (providers.DNSServiceProvider, error) {
return newHostingde(m, providermeta)
}
func newHostingdeReg(m map[string]string) (providers.Registrar, error) {
return newHostingde(m)
return newHostingde(m, json.RawMessage{})
}
func (hp *hostingdeProvider) GetNameservers(domain string) ([]*models.Nameserver, error) {
src, err := hp.getRecords(domain)
if err != nil {
return nil, err
}
var nameservers []string
for _, record := range src {
if record.Type == "NS" {
nameservers = append(nameservers, record.Content)
}
}
return models.ToNameservers(nameservers)
return models.ToNameserversStripTD(hp.nameservers)
}
func (hp *hostingdeProvider) GetZoneRecords(domain string) (models.Records, error) {