mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

CLOUDFLAREAPI: Fix TXT quoting bug (#1543)

Browse Source 
* Cleanup

* wip!

* Fix cloudflare quote bug

* wip!

* cleanup

* go generate
This commit is contained in:
Tom Limoncelli
2022-06-18 09:58:55 -04:00
committed by GitHub
parent bcb968411a
commit dad4115a55
7 changed files with 74 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
models/quotes.go
View File

@@ -20,6 +20,7 @@ func IsQuoted(s string) bool {
}
// StripQuotes returns the string with the starting and ending quotes removed.
// If it is not quoted, the original string is returned.
func StripQuotes(s string) string {
if IsQuoted(s) {
return s[1 : len(s)-1]
@@ -36,12 +37,20 @@ func ParseQuotedTxt(s string) []string {
if !IsQuoted(s) {
return []string{s}
}
// TODO(tlim): Consider using r, err := ParseQuotedFields(s)
return strings.Split(StripQuotes(s), `" "`)
}
// ParseQuotedFields is like strings.Fields except individual fields
// might be quoted using `"`.
func ParseQuotedFields(s string) ([]string, error) {
// Parse according to RFC1035 zonefile specifications.
// "foo" -> one string: `foo``
// "foo" "bar" -> two strings: `foo` and `bar`
// Quotes are escaped with \"
// Implementation note:
// Fields are space-separated but a field might be quoted. This is,
// essentially, a CSV where spaces are the field separator (not
// commas). Therefore, we use the CSV parser. See https://stackoverflow.com/a/47489846/71978