mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2024-05-11 05:55:12 +00:00
FEATURE: Detect simple CNAME loops (#2112)
This commit is contained in:
@ -187,6 +187,11 @@ func checkTargets(rec *models.RecordConfig, domain string) (errs []error) {
|
|||||||
if label == "@" {
|
if label == "@" {
|
||||||
check(fmt.Errorf("cannot create CNAME record for bare domain"))
|
check(fmt.Errorf("cannot create CNAME record for bare domain"))
|
||||||
}
|
}
|
||||||
|
labelFQDN := dnsutil.AddOrigin(label, domain)
|
||||||
|
targetFQDN := dnsutil.AddOrigin(target, domain)
|
||||||
|
if labelFQDN == targetFQDN {
|
||||||
|
check(fmt.Errorf("CNAME loop (target points at itself)"))
|
||||||
|
}
|
||||||
case "MX":
|
case "MX":
|
||||||
check(checkTarget(target))
|
check(checkTarget(target))
|
||||||
case "NAPTR":
|
case "NAPTR":
|
||||||
|
Reference in New Issue
Block a user