mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

FEATURE: Detect simple CNAME loops (#2112)

Browse Source
This commit is contained in:
Tom Limoncelli
2023-03-01 10:15:41 -05:00
committed by GitHub
parent b54c5eab10
commit dde7e5daf7
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/normalize/validate.go
View File

@ -187,6 +187,11 @@ func checkTargets(rec *models.RecordConfig, domain string) (errs []error) {
if label == "@" { if label == "@" {
check(fmt.Errorf("cannot create CNAME record for bare domain")) check(fmt.Errorf("cannot create CNAME record for bare domain"))
} }
labelFQDN := dnsutil.AddOrigin(label, domain)
targetFQDN := dnsutil.AddOrigin(target, domain)
if labelFQDN == targetFQDN {
check(fmt.Errorf("CNAME loop (target points at itself)"))
}
case "MX": case "MX":
check(checkTarget(target)) check(checkTarget(target))
case "NAPTR": case "NAPTR":