From e15b28c3b6c66a6aa1f92ba754a022b5767185e1 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Fri, 8 Sep 2017 17:13:59 -0400 Subject: [PATCH] ROUTE53: Fix broken integration test. --- integrationTest/integration_test.go | 4 ++-- pkg/js/helpers.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index 1affaa9af..703322bed 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -353,8 +353,8 @@ var tests = []*TestCase{ tc("CAA record", caa("@", "issue", 0, "letsencrypt.org")).IfHasCapability(providers.CanUseCAA), tc("CAA change tag", caa("@", "issuewild", 0, "letsencrypt.org")).IfHasCapability(providers.CanUseCAA), tc("CAA change target", caa("@", "issuewild", 0, "example.com")).IfHasCapability(providers.CanUseCAA), - tc("CAA change flag", caa("@", "issuewild", 1, "example.com")).IfHasCapability(providers.CanUseCAA), - tc("CAA many records", caa("@", "issue", 0, "letsencrypt.org"), caa("@", "issuewild", 0, ";"), caa("@", "iodef", 1, "mailto:test@example.com")).IfHasCapability(providers.CanUseCAA), + tc("CAA change flag", caa("@", "issuewild", 128, "example.com")).IfHasCapability(providers.CanUseCAA), + tc("CAA many records", caa("@", "issue", 0, "letsencrypt.org"), caa("@", "issuewild", 0, ";"), caa("@", "iodef", 128, "mailto:test@example.com")).IfHasCapability(providers.CanUseCAA), tc("CAA delete", caa("@", "issue", 0, "letsencrypt.org")).IfHasCapability(providers.CanUseCAA), // Test large zonefiles. diff --git a/pkg/js/helpers.js b/pkg/js/helpers.js index e367c4ecc..dae55262d 100644 --- a/pkg/js/helpers.js +++ b/pkg/js/helpers.js @@ -151,6 +151,7 @@ var ALIAS = recordBuilder('ALIAS'); // CAA(name,tag,value, recordModifiers...) var CAA = recordBuilder('CAA', { + // TODO(tlim): It should be an error if value is not 0 or 128. args: [ ['name', _.isString], ['tag', _.isString],