mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

INWX: Guard against single-quote TXT targets (#971)

Browse Source 
* INWX: split out and disable TXT with single-quote test
* INWX: add check for single-quotes in TXT records
This commit is contained in:
Sven Peter
2020-11-28 21:38:58 +01:00
committed by GitHub
parent d6b191bae4
commit e29f7440f5
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
providers/inwx/inwxProvider.go
View File

@@ -207,6 +207,18 @@ func (api *inwxAPI) deleteRecord(RecordID int) error {
return api.client.Nameservers.DeleteRecord(RecordID)
}
// checkRecords ensures that there is no single-quote inside TXT records which would be ignored by INWX.
func checkRecords(records models.Records) error {
for _, r := range records {
if r.Type == "TXT" {
if strings.ContainsAny(r.Target, "`") {
return fmt.Errorf("INWX TXT records do not support single-quotes in their target")
}
}
}
return nil
}
// GetDomainCorrections finds the currently existing records and returns the corrections required to update them.
func (api *inwxAPI) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correction, error) {
dc.Punycode()
@@ -218,6 +230,11 @@ func (api *inwxAPI) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Cor
models.PostProcessRecords(foundRecords)
err = checkRecords(dc.Records)
if err != nil {
return nil, err
}
differ := diff.New(dc)
_, create, del, mod, err := differ.IncrementalDiff(foundRecords)
if err != nil {