From e680fb9a46e4a618c473836f418feadfe3c6b1db Mon Sep 17 00:00:00 2001 From: Craig Peterson <192540+captncraig@users.noreply.github.com> Date: Thu, 23 Aug 2018 15:46:50 -0600 Subject: [PATCH] ROUTE53: Bug: fix corner case when deleting alias (#394) --- providers/route53/route53Provider.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/providers/route53/route53Provider.go b/providers/route53/route53Provider.go index 45baa0664..208535937 100644 --- a/providers/route53/route53Provider.go +++ b/providers/route53/route53Provider.go @@ -216,11 +216,14 @@ func (r *route53Provider) GetDomainCorrections(dc *models.DomainConfig) ([]*mode delDesc += strings.Join(namesToUpdate[k], "\n") + "\n" // on delete just submit the original resource set we got from r53. for _, r := range records { - if unescape(r.Name) == k.Name && (*r.Type == k.Type || k.Type == "R53_ALIAS") { + if unescape(r.Name) == k.Name && (*r.Type == k.Type || k.Type == "R53_ALIAS_"+*r.Type) { rrset = r break } } + if rrset == nil { + return nil, fmt.Errorf("No record set found to delete. Name: '%s'. Type: '%s'", k.Name, k.Type) + } } else { changes = append(changes, chg) changeDesc += strings.Join(namesToUpdate[k], "\n") + "\n"