Linting (#1087)

* fix linting
* rename AuditRecordsor to RecordAuditor
* gandi_v5 to gandiv5

providers/gandiv5/convert.go

@@ -0,0 +1,84 @@
+package gandiv5
+
+// Convert the provider's native record description to models.RecordConfig.
+
+import (
+	"fmt"
+
+	"github.com/go-gandi/go-gandi/livedns"
+
+	"github.com/StackExchange/dnscontrol/v3/models"
+	"github.com/StackExchange/dnscontrol/v3/pkg/printer"
+)
+
+// nativeToRecord takes a DNS record from Gandi and returns a native RecordConfig struct.
+func nativeToRecords(n livedns.DomainRecord, origin string) (rcs []*models.RecordConfig) {
+
+	// Gandi returns all the values for a given label/rtype pair in each
+	// livedns.DomainRecord.  In other words, if there are multiple A
+	// records for a label, all the IP addresses are listed in
+	// n.RrsetValues rather than having many livedns.DomainRecord's.
+	// We must split them out into individual records, one for each value.
+	for _, value := range n.RrsetValues {
+		rc := &models.RecordConfig{
+			TTL:      uint32(n.RrsetTTL),
+			Original: n,
+		}
+		rc.SetLabel(n.RrsetName, origin)
+		switch rtype := n.RrsetType; rtype {
+		case "ALIAS":
+			rc.Type = "ALIAS"
+			rc.SetTarget(value)
+		default: //  "A", "AAAA", "CAA", "NS", "CNAME", "MX", "PTR", "SRV", "TXT"
+			if err := rc.PopulateFromString(rtype, value, origin); err != nil {
+				panic(fmt.Errorf("unparsable record received from gandi: %w", err))
+			}
+		}
+		rcs = append(rcs, rc)
+	}
+
+	return rcs
+}
+
+func recordsToNative(rcs []*models.RecordConfig, origin string) []livedns.DomainRecord {
+	// Take a list of RecordConfig and return an equivalent list of ZoneRecords.
+	// Gandi requires one ZoneRecord for each label:key tuple, therefore we
+	// might collapse many RecordConfig into one ZoneRecord.
+
+	var keys = map[models.RecordKey]*livedns.DomainRecord{}
+	var zrs []livedns.DomainRecord
+
+	for _, r := range rcs {
+		label := r.GetLabel()
+		if label == "@" {
+			label = origin
+		}
+		key := r.Key()
+
+		if zr, ok := keys[key]; !ok {
+			// Allocate a new ZoneRecord:
+			zr := livedns.DomainRecord{
+				RrsetType:   r.Type,
+				RrsetTTL:    int(r.TTL),
+				RrsetName:   label,
+				RrsetValues: []string{r.GetTargetCombined()},
+			}
+			zrs = append(zrs, zr)
+			//keys[key] = &zr   // This didn't work.
+			keys[key] = &zrs[len(zrs)-1] // This does work. I don't know why.
+
+		} else {
+			zr.RrsetValues = append(zr.RrsetValues, r.GetTargetCombined())
+
+			if r.TTL != uint32(zr.RrsetTTL) {
+				printer.Warnf("All TTLs for a rrset (%v) must be the same. Using smaller of %v and %v.\n", key, r.TTL, zr.RrsetTTL)
+				if r.TTL < uint32(zr.RrsetTTL) {
+					zr.RrsetTTL = int(r.TTL)
+				}
+			}
+
+		}
+	}
+
+	return zrs
+}