Downcase DNS names (#253)

* Downcase DNS names
* Document opinions

providers/activedir/domains.go

@@ -46,6 +46,9 @@ func (c *adProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Co
 		return nil, fmt.Errorf("c.getExistingRecords(%v) failed: %v", dc.Name, err)
 	}
 
+	// Normalize
+	models.Downcase(foundRecords)
+
 	differ := diff.New(dc)
 	_, creates, dels, modifications := differ.IncrementalDiff(foundRecords)
 	// NOTE(tlim): This provider does not delete records.  If

providers/bind/bindProvider.go

@@ -237,6 +237,9 @@ func (c *Bind) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correcti
 		dc.Records = append(dc.Records, soaRec)
 	}
 
+	// Normalize
+	models.Downcase(foundRecords)
+
 	differ := diff.New(dc)
 	_, create, del, mod := differ.IncrementalDiff(foundRecords)
 

providers/cloudflare/cloudflareProvider.go

@@ -120,6 +120,10 @@ func (c *CloudflareApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models
 		}
 	}
 	checkNSModifications(dc)
+
+	// Normalize
+	models.Downcase(records)
+
 	differ := diff.New(dc, getProxyMetadata)
 	_, create, del, mod := differ.IncrementalDiff(records)
 	corrections := []*models.Correction{}

providers/digitalocean/digitaloceanProvider.go

@@ -101,6 +101,9 @@ func (api *DoApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Corre
 		existingRecords[i] = toRc(dc, &records[i])
 	}
 
+	// Normalize
+	models.Downcase(existingRecords)
+
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(existingRecords)
 

providers/dnsimple/dnsimpleProvider.go

@@ -90,6 +90,10 @@ func (c *DnsimpleApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.C
 		}
 		return true
 	})
+
+	// Normalize
+	models.Downcase(actual)
+
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(actual)
 

providers/gandi/gandiProvider.go

@@ -111,6 +111,10 @@ func (c *GandiApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Corr
 		recordsToKeep = append(recordsToKeep, rec)
 	}
 	dc.Records = recordsToKeep
+
+	// Normalize
+	models.Downcase(foundRecords)
+
 	differ := diff.New(dc)
 	_, create, del, mod := differ.IncrementalDiff(foundRecords)
 

providers/gcloud/gcloudProvider.go

@@ -136,6 +136,9 @@ func (g *gcloud) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correc
 		want.MergeToTarget()
 	}
 
+	// Normalize
+	models.Downcase(existingRecords)
+
 	// first collect keys that have changed
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(existingRecords)

providers/namecheap/namecheapProvider.go

@@ -155,6 +155,9 @@ func (n *Namecheap) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Cor
 		actual = append(actual, rec)
 	}
 
+	// Normalize
+	models.Downcase(actual)
+
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(actual)
 

providers/namedotcom/records.go

@@ -37,6 +37,9 @@ func (n *nameDotCom) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Co
 
 	checkNSModifications(dc)
 
+	// Normalize
+	models.Downcase(actual)
+
 	differ := diff.New(dc)
 	_, create, del, mod := differ.IncrementalDiff(actual)
 	corrections := []*models.Correction{}

providers/ns1/ns1provider.go

@@ -66,6 +66,9 @@ func (n *nsone) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Correct
 	foundGrouped := found.Grouped()
 	desiredGrouped := dc.Records.Grouped()
 
+	//  Normalize
+	models.Downcase(found)
+
 	differ := diff.New(dc)
 	changedGroups := differ.ChangedGroups(found)
 	corrections := []*models.Correction{}

providers/route53/route53Provider.go

@@ -170,6 +170,9 @@ func (r *route53Provider) GetDomainCorrections(dc *models.DomainConfig) ([]*mode
 		want.MergeToTarget()
 	}
 
+	// Normalize
+	models.Downcase(existingRecords)
+
 	//diff
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(existingRecords)

providers/softlayer/softlayerProvider.go

@@ -163,6 +163,9 @@ func (s *SoftLayer) getExistingRecords(domain *datatypes.Dns_Domain) ([]*models.
 		actual = append(actual, recConfig)
 	}
 
+	// Normalize
+	models.Downcase(actual)
+
 	return actual, nil
 }
 

providers/vultr/vultrProvider.go

@@ -97,6 +97,9 @@ func (api *VultrApi) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Co
 		curRecords[i] = r
 	}
 
+	// Normalize
+	models.Downcase(curRecords)
+
 	differ := diff.New(dc)
 	_, create, delete, modify := differ.IncrementalDiff(curRecords)