mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

LETS_ENCRYPT: Try all cert renewals before returning error. (#611)

Browse Source
This commit is contained in:
Tom Limoncelli
2020-01-30 16:29:39 -05:00
committed by GitHub
parent e172df2817
commit fcccb2b9dc
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
commands/getCerts.go
View File

@ -184,6 +184,7 @@ func GetCerts(args GetCertsArgs) error {
if err != nil { if err != nil {
return err return err
} }
var manyerr error
for _, cert := range certList { for _, cert := range certList {
if args.Only != "" && cert.CertName != args.Only { if args.Only != "" && cert.CertName != args.Only {
continue continue
@ -194,11 +195,15 @@ func GetCerts(args GetCertsArgs) error {
notifier.Notify(cert.CertName, "certificate", "Issued new certificate", err, false) notifier.Notify(cert.CertName, "certificate", "Issued new certificate", err, false)
} }
if err != nil { if err != nil {
return err if manyerr == nil {
manyerr = err
} else {
manyerr = fmt.Errorf("%w; %v", manyerr, err)
}
} }
} }
notifier.Done() notifier.Done()
return nil return manyerr
} }
var validCertNamesRegex = regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_\-]*$`) var validCertNamesRegex = regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_\-]*$`)