mirror of
https://github.com/StackExchange/dnscontrol.git
synced 2024-05-11 05:55:12 +00:00
c8a5060dfb
* Emit warning in case of label having multiple TTLs An RRSet (=label) consisting of multiple records with different TTLs is something not supported by most providers, and should be avoided. Furthermore it is deprecated in rfc2181#section-5.2 Emit a warning for now during validation, eventually turning it into a full-blown error. Fixes #1372 * normalize: less verbose checkLabelHasMultipleTTLs Code would previously emit a warning for each record it found matching a previously found label but with a different ttl. This could potentially become too verbose of an output for larger zones. Split the loop into two loops, one storing labels and their records' TTLs, the second checking for multiple TTLs, in order to minimize the messages logged to one message per problematic label, regardless for the number of records involved. Co-authored-by: Tom Limoncelli <tlimoncelli@stackoverflow.com>