pping/TODO.md

# TODO

## For initial merge
- [x] Clean up commits and add signed-off-by tags
- [x] Add SPDX-license-identifier tags
- [x] Format C-code in kernel style
- [x] Use existing funcionality to reuse maps by using BTF-defined maps
  - [x] Use BTF-defined maps for TC-BPF as well if iproute has libbpf support

## Future
- [ ] Use libxdp to load XDP program
- [x] Cleanup: Unload TC-BPF at program shutdown, and unpin map - In userspace part
- [ ] Add IPv6 support - In TC-BPF, XDP and userspace part
- [ ] Check for existance of reverse flow before adding to hash-map (to avoid adding timestamps for flows that we can't see the reverse traffic for) - In TC-BPF part
  -  This could miss the first few packets, would not be ideal for short flows
- [ ] Keep track of minimum RTT for each flow (done by Pollere's pping, and helps identify buffer bloat) - In XDP part
- [ ] Add configurable rate-limit for how often each flow can add entries to the map (prevent high-rate flows from quickly filling up the map) - In TCP-BPF part
- [ ] Improve map cleaning: Use a dynamic time to live for hash map entries based on flow's RTT, instead of static 10s limit - In TC-BPF, XDP and userspace
pping: Format code and add SPDX lincense tags Format the code using the .clang-format from the kernel source tree, with a few manual tweaks here and there. Also, remove the TODO list from comment of pping.c and instead put it in TODO.md. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 13:13:51 +01:00			`# TODO`

			`## For initial merge`
			`- [x] Clean up commits and add signed-off-by tags`
			`- [x] Add SPDX-license-identifier tags`
			`- [x] Format C-code in kernel style`
pping: Let libbpf pin map and clean up TC and map at end Switch order so XDP program loads first, so the ts_start map is automatically pinned by libbpf (solves issue with tc not preserving the name of the map). Unload the TCP-BPF program (or rather remove the entire clsact qdisc it is attached to) using bpg_egress_loader script once program exits. Also unpin ts_start map on program shutdown. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-21 17:52:08 +01:00			`- [x] Use existing funcionality to reuse maps by using BTF-defined maps`
pping: Various minor fixes Perform various fixes and tweaks: - Rename several defines to make them more informative - Remove unrolling of loop in BPF programs - Reuse defines for program sections between userspace and kernel space programs - Perform fork+exec to run bpf_egress_loader script instead of system() - Add comment to copied scripts indicating I've modified them - Add pping.h and pping_helpers.h as dependencies in Makefile Also, add a brief description of what PPing is and how it works to README Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-26 18:34:23 +01:00			`- [x] Use BTF-defined maps for TC-BPF as well if iproute has libbpf support`
pping: Format code and add SPDX lincense tags Format the code using the .clang-format from the kernel source tree, with a few manual tweaks here and there. Also, remove the TODO list from comment of pping.c and instead put it in TODO.md. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 13:13:51 +01:00
			`## Future`
pping: Format headers and fix TODO.md Format the header files in the Linux kernel style (missed in previous commit). Also fix a formating error in TODO.md that cause empty checkboxes to not display correctly. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 18:08:35 +01:00			`- [ ] Use libxdp to load XDP program`
pping: Let libbpf pin map and clean up TC and map at end Switch order so XDP program loads first, so the ts_start map is automatically pinned by libbpf (solves issue with tc not preserving the name of the map). Unload the TCP-BPF program (or rather remove the entire clsact qdisc it is attached to) using bpg_egress_loader script once program exits. Also unpin ts_start map on program shutdown. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-21 17:52:08 +01:00			`- [x] Cleanup: Unload TC-BPF at program shutdown, and unpin map - In userspace part`
pping: Format headers and fix TODO.md Format the header files in the Linux kernel style (missed in previous commit). Also fix a formating error in TODO.md that cause empty checkboxes to not display correctly. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 18:08:35 +01:00			`- [ ] Add IPv6 support - In TC-BPF, XDP and userspace part`
			`- [ ] Check for existance of reverse flow before adding to hash-map (to avoid adding timestamps for flows that we can't see the reverse traffic for) - In TC-BPF part`
pping: Format code and add SPDX lincense tags Format the code using the .clang-format from the kernel source tree, with a few manual tweaks here and there. Also, remove the TODO list from comment of pping.c and instead put it in TODO.md. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 13:13:51 +01:00			`- This could miss the first few packets, would not be ideal for short flows`
pping: Format headers and fix TODO.md Format the header files in the Linux kernel style (missed in previous commit). Also fix a formating error in TODO.md that cause empty checkboxes to not display correctly. Signed-off-by: Simon Sundberg <simon.sundberg@kau.se> 2021-01-18 18:08:35 +01:00			`- [ ] Keep track of minimum RTT for each flow (done by Pollere's pping, and helps identify buffer bloat) - In XDP part`
			`- [ ] Add configurable rate-limit for how often each flow can add entries to the map (prevent high-rate flows from quickly filling up the map) - In TCP-BPF part`
			`- [ ] Improve map cleaning: Use a dynamic time to live for hash map entries based on flow's RTT, instead of static 10s limit - In TC-BPF, XDP and userspace`