mirror/xdp-project-bpf-examples
1
0
Fork 0
mirror of https://github.com/xdp-project/bpf-examples.git synced 2024-05-06 15:54:53 +00:00
Code Issues Projects Releases Wiki Activity

pkt-loop-filter: Fix off-by-one in bounds check

Browse Source 
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
This commit is contained in:
Toke Høiland-Jørgensen
2022-06-28 16:13:48 +02:00
parent e9aeda404e
commit e4530b04ce
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkt-loop-filter/pkt-loop-filter.kern.c
View File

@@ -50,7 +50,7 @@ unsigned int current_ifindex = 0;
static int get_current_ifindex(void) static int get_current_ifindex(void)
{ {
/* bounds check to placate the verifier */ /* bounds check to placate the verifier */
if (current_ifindex > MAX_IFINDEXES) if (current_ifindex >= MAX_IFINDEXES)
return 0; return 0;
return active_ifindexes[current_ifindex]; return active_ifindexes[current_ifindex];
@@ -145,7 +145,7 @@ int BPF_KPROBE(handle_device_notify, unsigned long val, struct netdev_notifier_i
* don't check for ifup and switch back * don't check for ifup and switch back
*/ */
current_ifindex++; current_ifindex++;
if (current_ifindex > MAX_IFINDEXES || !active_ifindexes[current_ifindex]) if (current_ifindex >= MAX_IFINDEXES || !active_ifindexes[current_ifindex])
current_ifindex = 0; current_ifindex = 0;
} }