From f74905ca718b72b3857447622f0cc0498f060960 Mon Sep 17 00:00:00 2001 From: Koichi Murase Date: Sun, 28 Apr 2024 04:38:23 +0900 Subject: [PATCH] CONTRIBUTING: update description of the theme images --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f7b046d..aadff40 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -98,7 +98,11 @@ maintainers) by mentioning their GitHub handle (starting with `@`) in your messa For any extensive change, _eg_ a new plugin, you will have to find testers to +1 your PR. When you add new themes, please also update [themes/THEMES.md](https://github.com/ohmybash/oh-my-bash/blob/master/themes/THEMES.md). -The theme needs to have exactly one image of height ~290px and width 600--800px. +The theme needs to have exactly one image file. The image size needs to be +height ~290px and width 600..800px to make the theme gallery aligned and also +to keep the repository size small. The filename should be +`-dark.png` or `-light.png` depending on the dark or +light background of the terminal used to make the image. After your new themes are merged, the list in [Themes](https://github.com/ohmybash/oh-my-bash/wiki/Themes) in the Wiki also needs to be updated. ----