mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code

addons: address: warn user if L3-SVI is configured with "ip-forward off"

Browse Source 
Context:
"user accidentally disabled ip4 and ip6 forwarding on the L3-SVI for all VRF's.
we should add a check in ifupdown2 to warn user this is a bad config (symmetric
routing will not work if routing is disabled in this way)."

Signed-off-by: Julien Fortin <jfortin@nvidia.com>
This commit is contained in:
Julien Fortin
2021-04-08 02:07:04 +02:00
parent 9c1176c849
commit 0b34071bf8
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
ifupdown2/addons/address.py
View File

@ -271,7 +271,24 @@ class address(AddonWithIpBlackList, moduleBase):
and self.syntax_check_addr_allowed_on(ifaceobj, True)
and self.syntax_check_mtu(ifaceobj, ifaceobj_getfunc)
and self.syntax_check_sysctls(ifaceobj)
and self.syntax_check_enable_l3_iface_forwardings(ifaceobj, ifaceobj_getfunc, syntax_check=True))
and self.syntax_check_enable_l3_iface_forwardings(ifaceobj, ifaceobj_getfunc, syntax_check=True)
and self.syntax_check_l3_svi_ip_forward(ifaceobj))
def syntax_check_l3_svi_ip_forward(self, ifaceobj):
if ifaceobj.link_kind & ifaceLinkKind.VLAN and ifaceobj.link_privflags & ifaceLinkPrivFlags.VRF_SLAVE:
ip_forward = ifaceobj.get_attr_value_first("ip-forward")
if ip_forward and not utils.get_boolean_from_string(ip_forward):
self.log_error("%s: misconfiguration: disabling ip4 forwarding on an l3-svi is not allowed" % ifaceobj.name, ifaceobj)
return False
ip6_forward = ifaceobj.get_attr_value_first("ip6-forward")
if ip6_forward and not utils.get_boolean_from_string(ip6_forward):
self.log_error("%s: misconfiguration: disabling ip6 forwarding on an l3-svi is not allowed" % ifaceobj.name, ifaceobj)
return False
return True
def syntax_check_enable_l3_iface_forwardings(self, ifaceobj, ifaceobj_getfunc, syntax_check=False):
if (self.enable_l3_iface_forwarding_checks
@ -832,6 +849,9 @@ class address(AddonWithIpBlackList, moduleBase):
return
if not self.syntax_check_sysctls(ifaceobj):
return
if not self.syntax_check_l3_svi_ip_forward(ifaceobj):
return
ipforward = ifaceobj.get_attr_value_first('ip-forward')
ip6forward = ifaceobj.get_attr_value_first('ip6-forward')
if ifupdownflags.flags.PERFMODE: