mirror of
https://github.com/CumulusNetworks/ifupdown2.git
synced 2024-05-06 15:54:50 +00:00
Fix upperiface check when ifdown is run with -a
Ticket: CM-3007 Reviewed By: shm + patch was pasted in the bug for review Testing Done: ran precommit + maliks test + malik ran his test on his box When -a is specified ifupdown2 works on all interfaces and since the the upperiface check is a bit expensive i had a "skip" on that. And so far all the user commands i have seen only work on the $IFACE and not its dependents. So, never hit this case.
This commit is contained in:
@@ -150,12 +150,14 @@ class ifaceScheduler():
|
|||||||
if (ifupdownobj.FORCE or
|
if (ifupdownobj.FORCE or
|
||||||
not ifupdownobj.ADDONS_ENABLE or
|
not ifupdownobj.ADDONS_ENABLE or
|
||||||
(not ifupdownobj.is_ifaceobj_noconfig(ifaceobj) and
|
(not ifupdownobj.is_ifaceobj_noconfig(ifaceobj) and
|
||||||
ifupdownobj.config.get('warn_on_ifdown', '0') == '0')):
|
ifupdownobj.config.get('warn_on_ifdown', '0') == '0' and
|
||||||
|
not ifupdownobj.ALL)):
|
||||||
return True
|
return True
|
||||||
|
|
||||||
ulist = ifaceobj.upperifaces
|
ulist = ifaceobj.upperifaces
|
||||||
if not ulist:
|
if not ulist:
|
||||||
return True
|
return True
|
||||||
|
|
||||||
# Get the list of upper ifaces other than the parent
|
# Get the list of upper ifaces other than the parent
|
||||||
tmpulist = ([u for u in ulist if u != parent] if parent
|
tmpulist = ([u for u in ulist if u != parent] if parent
|
||||||
else ulist)
|
else ulist)
|
||||||
|
|||||||
Reference in New Issue
Block a user