mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code

addons: addressvirtual: error in VRR mac address changes exit code (1)

Browse Source 
$ ifquery -a
auto bridge
iface bridge
      bridge-vlan-aware yes
      bridge-ports swp1

auto bridge.2
iface bridge.2
      address-virtual 01:01:01:02:02:02	1.10.10.10/32

$ ifup -a
error: bridge.2: Multicast bit is set in the virtual mac address '01:01:01:02:02:02'
$ echo $?
1
$

Reviewed-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: Julien Fortin <julien@cumulusnetworks.com>
This commit is contained in:
Julien Fortin
2018-07-02 12:20:07 +02:00
parent 79cde97bbd
commit 5b1fffafcd
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ifupdown2/addons/addressvirtual.py
View File

@ -378,10 +378,11 @@ class addressvirtual(moduleBase):
mac = mac.lower()
try:
if int(mac.split(":")[0], 16) & 1 :
self.logger.error("%s: Multicast bit is set in the virtual mac address '%s'" %(ifaceobj.name, mac))
self.log_error("%s: Multicast bit is set in the virtual mac address '%s'"
% (ifaceobj.name, mac), ifaceobj=ifaceobj)
return False
return True
except Exception:
except ValueError:
return False
def _fixup_vrf_enslavements(self, ifaceobj, ifaceobj_getfunc=None):