mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code Activity

ifupdown2 ethtool does not handle link-* settings on enslaved ports

Browse Source 
Ticket: CM-7128
Reviewed By: Trivial
Testing Done: unit tested on Ken's machine

The ifupdown2 ethtool addon module fails to set/check
the link-speed on bridge ports.
I removed excessive ifaceLinkKind checking since CM-6619
(03642a9a) added BRIDGE_PORT and BOND_SLAVE.  This is ok
since we now check to see if ports have defaults (only swp do)
before showing or changing settings).
This commit is contained in:
Sam Tannous
2015-08-20 23:12:26 -04:00
parent 1e6d7bd76c
commit 7496605db3
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
addons/ethtool.py
View File

@@ -236,13 +236,6 @@ class ethtool(moduleBase,utilsBase):
if not op_handler:
return
self._init_command_handlers()
# while this will not catch all interface kinds, we try for most here
# we should only be running ethtool on real, hardware devices. For
# newer interfaces that do not set link_kind, they should not have
# a default attribute setting since update-ports only generates
# settings for hardware ports.
if ifaceobj.link_kind != ifaceLinkKind.UNKNOWN:
return
if operation == 'query-checkcurr':
op_handler(self, ifaceobj, query_ifaceobj)