mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code Activity

Warn when bond-min-links is absent or set to '0'

Browse Source 
Ticket: CM-4327
Reviewed By:
Testing Done: Tested bond config without the bond-min-links attribute
This commit is contained in:
Roopa Prabhu
2015-01-02 18:20:15 -08:00
parent 0ba357128e
commit 782fa53938
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
addons/ifenslave.py
View File

@@ -158,6 +158,13 @@ class ifenslave(moduleBase):
int(attrval) > int(validrange[1])): int(attrval) > int(validrange[1])):
raise Exception(msg + ' Valid range is [%s,%s]' raise Exception(msg + ' Valid range is [%s,%s]'
%(validrange[0], validrange[1])) %(validrange[0], validrange[1]))
if attrname == 'bond-mode' and attrval == '802.3ad':
dattrname = 'bond-min-links'
min_links = ifaceobj.get_attr_value_first(dattrname)
if not min_links or min_links == '0':
self.logger.warn('%s: required attribute %s'
%(ifaceobj.name, dattrname) +
' not present or set to \'0\'')
elif attrname in ['bond-lacp-bypass-allow']: elif attrname in ['bond-lacp-bypass-allow']:
# For some attrs, set default values # For some attrs, set default values
optiondict = self.get_mod_attr(attrname) optiondict = self.get_mod_attr(attrname)