mirror/CumulusNetworks-ifupdown2
1
0
Fork 0
mirror of https://github.com/CumulusNetworks/ifupdown2.git synced 2024-05-06 15:54:50 +00:00
Code
170 Commits 14 Branches 46 Tags
Commit Graph

170 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Roopa Prabhu
e160136944 Bug fixes and some query support 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity testing and syntax testing for new bridge driver
 2014-10-28 16:10:00 -07:00
Roopa Prabhu
1d591e73b5 Include '-' in regex for globs 
Ticket: CM-3346
Reviewed By:
Testing Done: Sanity test
 2014-10-24 20:48:38 -07:00
Roopa Prabhu
7baa2093ba Fix bridge port vid settings during ifup of a bridge port 
Ticket: CM-3346
Reviewed By:
Testing Done: ifupdown2 sanity test for the new bridge driver
 2014-10-24 20:43:50 -07:00
Roopa Prabhu
fe91c3484f remove code that makes a bridge port inherit stp/mstp/igmp attributes from bridge 
Ticket: CM-4035
Reviewed By:
Testing Done: Tested ifupdown2 sanity
 2014-10-24 14:21:54 -07:00
Roopa Prabhu
84ca006f82 First phase checkin for new format for vlan aware bridge 
Ticket: CM-3346
Reviewed By:
Testing Done: Sanity test + test new bridge format

There are a bunch of open issues with `vlan` interface handling.
Below is the format.

auto swp1
iface swp1
    bridge-access 300
    mstpctl-pathcost 0
    mstpctl-adminedge yes
    mstpctl-autoedge yes
    mstpctl-p2p yes
    mstpctl-bpduguard yes
    mstpctl-treeprio 64
    mstpctl-network yes
    mstpctl-bpdufilter yes

auto swp2
iface swp2
    bridge-vids 301
    bridge-pvid 302
    bridge-pathcost 10
    bridge-priority 10
    bridge-multicast-router 0
    bridge-multicast-fast-leave 1

auto br0
iface br0
    bridge-vlan-aware yes
    bridge-stp on
    bridge-ports swp1 swp2
    bridge-vids 2001

auto br0.2001
iface br0.2001
    address 10.0.14.2
    hwaddress 00:03:00:00:00:12
    address-virtual 00:00:5e:00:01:01 11.0.4.1/24

auto br0.2001
vlan br0.2001
    bridge-igmp-querier-src 172.16.101.1
 2014-10-24 10:11:07 -07:00
Roopa Prabhu
48ca05db88 Fix missing import due to merge 
Ticket:
Reviewed By:
Testing Done:
 2014-10-22 13:42:08 -07:00
Roopa Prabhu
c2d55ff5f2 Fix bridge deletion 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested bridge up/down
 2014-10-13 10:07:36 -07:00
Roopa Prabhu
61636dcc1c Set RLIMIT_CORE to zero. For some reason the core file size is huge. 
Ticket: CM-3346
Reviewed By:
Testing Done: ifupdown2 sanity

I dont see a real reason for a core file to debug ifupdown2 problems
currently. Will re-enable core file generation when i root cause the
issue.
 2014-10-13 09:55:21 -07:00
Roopa Prabhu
e74d01e1b2 Add rtnetlink api's for link creates 
Ticket: CM-3346
Reviewed By:
Testing Done:
 2014-10-12 13:50:05 -07:00
Roopa Prabhu
e57b12e75a Replace check mark by none and cross mark by ascii 'x' in --check output 
Ticket: CM-3810
Reviewed By:
Testing Done:

These are configurable via strings check_success_str and check_error_str
in /etc/network/ifupdown2/ifupdown2.conf
 2014-10-10 14:52:11 -07:00
Roopa Prabhu
8c13865cd4 Fix a few ordering issues + fix following upperiface for bridge device 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity test
 2014-10-10 14:05:19 -07:00
Roopa Prabhu
667d62f587 Make query check a no-op for the vlan aware bridge until correctly fixed 
Ticket: CM-3346
Reviewed By:
Testing Done: sanity test
 2014-10-09 21:22:12 -07:00
Roopa Prabhu
d101ece27b Remove stale mstp adminadge attributes 
Ticket: CM-3346
Reviewed By: sashok
Testing Done: sanity test
 2014-10-09 19:26:10 -07:00
Roopa Prabhu
39804250c7 A few more fixes to the vlan aware bridge case 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested with new and old bridge formats
 2014-10-09 19:10:20 -07:00
Roopa Prabhu
15ef32ea14 Move ifupdown2addons into ifupdown2 pacakge 
Ticket: CM-3864
Reviewed By:
Testing Done: Tested build and install

open item:
- cleanup stale ifupdown2-addons package files
 2014-10-09 16:02:46 -07:00
Roopa Prabhu
679e656768 more support and fixes to support new format for vlan filtering bridge 
Ticket: CM-3346
Reviewed By:
Testing Done: Tested with old and new formats

Details of the format are attached to the bug.
 2014-10-09 12:58:16 -07:00
Roopa Prabhu
41febf8975 support for new bridge driver syntax 
Ticket: CM-3346
Reviewed By:
Testing Done: tested vmware interfaces file with old and new formats

details:
- move bridge port membership to under the port
- move bridge port attributes under ports
- bridge attributes continue to remain under bridge
- special vlan interface for vlan attributes and svi config (iface
vlan-<vlanid/range>)
- maintain backward compatibility with all previously released bridge
config formats for vlan aware bridge

Open issues:
- check and running support will be done part of CM-3784
- ifquery currently expands and prints all the vlan-* interfaces.
 2014-10-06 11:11:10 -07:00
Roopa Prabhu
ee3fcf4431 Minor fixes for multiple interfaces with the same config + performance 
fix for the dependency graph generator code

Ticket:
Reviewed By:
Testing Done: sanity test
 2014-09-26 14:23:15 -07:00
Roopa Prabhu
0fb49cf59d Initial checkin for ifup/ifdown svi config 
Ticket:
Reviewed By:
Testing Done: Tested with old and new bridge driver

Examples:
old bridge driver:
%for v in range(100, 104):
auto br${v}
iface br${v}
    bridge-ports uplink1.${v} peerlink.${v} downlink.${v} glob
swp2-4.${v}
    bridge-stp on
    svi-router-ip 11.${v/256}.${v%256}.240/24
    svi-router-mac 00:00:5e:00:01:00
    svi-router-virtual-ip 11.${v/256}.${v%256}.241/24
    svi-router-virtual-mac 00:11:22:33:44:00
%endfor

new bridge driver:
%for v in range(100, 101):
auto br0.${v}
iface br0.${v}
    svi-router-ip 11.${v/256}.${v%256}.240/24
    svi-router-mac 00:00:5e:00:01:00
    svi-router-virtual-ip 11.${v/256}.${v%256}.241/24
    svi-router-virtual-mac 00:11:22:33:44:00
%endfor

Pending issues:
- optimization (its slow with 2000 svi's today)
- ifquery check and running support
- names of attributes and macvlan interfaces may change after review
 2014-09-25 10:57:52 -07:00
Cumulus Builds
5ac39f5e4f Merge branch 'master' of ssh://dev.cumulusnetworks.com/home/trac/cumulus 
Conflicts:
	patches/bcm-sdk/series
 2014-08-30 15:38:46 -07:00
Cumulus Builds
585a9a8a35 Merge branch 'vmware_L2' 
Conflicts:
	build-config/conf/extra-pkgs
	build-config/conf/linux.vci.config
	build-config/conf/snapshot-manifest-amd64
	build-config/conf/version
	build-config/make/bcm-sdk.make
	build-config/make/local-pkgs.make
	build-config/make/local-pkgs2.make
	packages/cafe/scripts/build.py
	packages/cl-platform-config/usr/share/platform-config/accton/as6701_32x/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/cel/smallstone/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/dell/s6000_s1220/etc/bcm.d/config.d/01config.bcm
	packages/cl-utilities/usr/share/cumulus/support/functions
	packages/cl-utilities/usrlib/datapath-update
	packages/clag/init.d/clagd
	packages/clag/man/clagctl.8
	packages/clag/sbin/clagctl
	packages/clag/sbin/clagd
	packages/clag/setup.py
	packages/ifupdown2-addons/addons/bridge.py
	packages/ifupdown2-addons/pkg/bridgeutils.py
	packages/ifupdown2-addons/pkg/ifenslaveutil.py
	packages/ifupdown2-addons/pkg/iproute2.py
	packages/ifupdown2-addons/pkg/modulebase.py
	packages/ifupdown2/pkg/ifupdownmain.py
	packages/ifupdown2/pkg/networkinterfaces.py
	packages/ifupdown2/pkg/scheduler.py
	packages/portwd/portwd
	packages/ptm/ptm_conf.c
	patches/bcm-sdk/series
	patches/bridge-utils/series
	patches/iproute/fix-bridge-batch.patch
	patches/iproute/fix-fdb-add.patch
	patches/iproute/ip-add-batch-mode-to-man-page.patch
	patches/iproute/series
	patches/iproute/show-fdb-bridge.patch
	patches/kernel/debian-cumulus-controlfiles.patch
	patches/kernel/network-bridge-fdb-learn-priority.patch
	patches/kernel/network-bridge-igmp-fast-leave.patch
	patches/kernel/network-bridge-igmpv3.patch
	patches/kernel/network-bridge-querier-ifaddr.patch
	patches/kernel/network-bridge-use-spin_lock_bh-from-process-context.patch
	patches/kernel/network-tun-ethtool.patch
	patches/kernel/network-vxlan-fix-fdb-update.patch
	patches/kernel/series
	patches/libnl/series
	rootconf/default/etc/cumulus/switchd.conf
	switchd/hal.c
	switchd/hal.h
	switchd/hal_bcm.c
	switchd/hal_bcm_vxlan.c
	switchd/hal_config.c
	switchd/hal_dummy.c
	switchd/hal_int.h
	switchd/hal_util.c
	switchd/switchd.c
	switchd/sync.c
	tests/config/__init__.py
	tests/config/default.cfg
	tests/examples/testssim2.py
	tests/infra/testssim2.py
	tests/smoke/testifupdown2.py
	tests/tests/examples/testssim2.py
	utilities/distro-cmd
	utilities/packages/ssim2/simlib.py
	utilities/packages/testfu/scripts/runteststmpl.sh
	utilities/packages/testfu/scripts/xmltoresults.py
 2014-08-30 12:35:23 -07:00
Roopa Prabhu
acc7dbc5e3 Fix leftover func call possibly due to merge + some cleanup 
Ticket: CM-3542
Reviewed By:
Testing Done:
 2014-08-26 16:17:49 -07:00
Roopa Prabhu
c2e8e93e1d Fix a few options 
Ticket: CM-3529
Reviewed By:
Testing Done: checked man pages
 2014-08-26 14:19:13 -07:00
Cumulus Builds
1d46fe02eb Merge branch 'CumulusLinux-2.1_br' 
Conflicts:
	build-config/Makefile
	build-config/conf/extra-pkgs
	build-config/conf/linux.amd64.config
	build-config/conf/linux.powerpc-e500.config
	build-config/conf/linux.vci.config
	build-config/conf/snapshot-manifest-amd64
	build-config/conf/snapshot-manifest-powerpc
	build-config/installer/arch/amd64-installer-functions
	build-config/installer/cumulus/init/im_n29xx_t40n/platform.conf
	build-config/make/bcm-sdk.make
	build-config/make/images.make
	build-config/make/kernel.make
	build-config/make/lkm.make
	build-config/make/local-pkgs.make
	build-config/make/local-pkgs2.make
	build-config/scripts/kernel-builddeb
	build-config/scripts/mkimage-amd64.sh
	modules/Makefile
	modules/accton_as5712_54x_platform.c
	modules/cel_redstone_xp_muxpld.c
	modules/dell_s6000_platform.c
	modules/platform_defs.h
	packages/cafe/clobjects.py
	packages/cafe/scripts/build.py
	packages/cafe/scripts/supporttarball.py
	packages/cafe/scripts/test_ci.sh
	packages/cl-basefiles/etc/cumulus/datapath/traffic.conf
	packages/cl-image/bin/cl-img-install
	packages/cl-image/bin/cl-img-select
	packages/cl-image/img/functions
	packages/cl-platform-config/usr/share/platform-config/accton/as5712_54x/bin/eeprom.py
	packages/cl-platform-config/usr/share/platform-config/accton/as5712_54x/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/accton/as5712_54x/etc/modules
	packages/cl-platform-config/usr/share/platform-config/accton/as5712_54x/etc/sensors.d/accton_as5712_54x.conf
	packages/cl-platform-config/usr/share/platform-config/accton/as6701_32x/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/bin/eeprom.py
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/bcm.d/default_config_values
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/bcm.d/hw_desc
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/bcm.d/rc.soc
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/modules
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/etc/sensors.d/cel_redstone_xp.conf
	packages/cl-platform-config/usr/share/platform-config/cel/redstone_xp/hw_init.d/S20qsfp_init.sh
	packages/cl-platform-config/usr/share/platform-config/cel/smallstone/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/dell/s6000_s1220/bin/eeprom.py
	packages/cl-platform-config/usr/share/platform-config/dell/s6000_s1220/etc/bcm.d/config.d/01config.bcm
	packages/cl-platform-config/usr/share/platform-config/dell/s6000_s1220/etc/modules
	packages/cl-platform-config/usr/share/platform-config/dell/s6000_s1220/etc/sensors.d/dell_s6000_s1220.conf
	packages/cl-platform-config/usr/share/platform-config/dni/c7448n/etc/bcm.d/default_config_values
	packages/cl-platform-config/usr/share/platform-config/dni/c7448n/etc/bcm.d/hw_desc
	packages/cl-platform-config/usr/share/platform-config/im/n29xx_t40n/etc/bcm.d/rc.soc
	packages/cl-platform-config/usr/share/platform-config/im/n29xx_t40n/etc/cumulus/ports.conf
	packages/cl-platform-config/usr/share/platform-config/quanta/ly6_p2020/etc/bcm.d/config.d/01config.bcm
	packages/cl-utilities/dist-packages/cumulus/__chip_config/bcm/Trident/rc.forwarding
	packages/cl-utilities/dist-packages/cumulus/__chip_config/bcm/TridentTwo/rc.forwarding
	packages/cl-utilities/dist-packages/cumulus/__chip_config/bcm/Triumph/rc.forwarding
	packages/cl-utilities/dist-packages/cumulus/__chip_config/bcm/datapath.conf
	packages/cl-utilities/dist-packages/cumulus/platform.py
	packages/cl-utilities/dist-packages/cumulus/platforms/accton.py
	packages/cl-utilities/dist-packages/cumulus/platforms/cel.py
	packages/cl-utilities/dist-packages/cumulus/platforms/dell.py
	packages/cl-utilities/dist-packages/cumulus/platforms/quanta.py
	packages/cl-utilities/dist-packages/cumulus/portconfig.py
	packages/cl-utilities/dist-packages/cumulus/sensors.py
	packages/cl-utilities/rst/pwmd.8.rst
	packages/cl-utilities/rst/smonctl.8.rst
	packages/cl-utilities/usrlib/datapath-config
	packages/cl-utilities/usrlib/datapath-update
	packages/cl-utilities/usrlib/update-ports
	packages/clag/man/clagctl.8
	packages/clag/man/clagd.8
	packages/clag/sbin/clagctl
	packages/clag/sbin/clagd
	packages/clag/setup.py
	packages/ifupdown2-addons/addons/bridge.py
	packages/ifupdown2-addons/addons/mstpctl.py
	packages/ifupdown2-addons/pkg/bridgeutils.py
	packages/ifupdown2-addons/pkg/ifenslaveutil.py
	packages/ifupdown2-addons/pkg/modulebase.py
	packages/ifupdown2/init.d/networking
	packages/ifupdown2/pkg/iface.py
	packages/ifupdown2/pkg/ifupdownbase.py
	packages/ifupdown2/pkg/ifupdownmain.py
	packages/ifupdown2/pkg/networkinterfaces.py
	packages/ifupdown2/pkg/scheduler.py
	packages/ifupdown2/sbin/ifupdown
	packages/iorw/Makefile
	packages/iorw/iorw.c
	packages/lnv/debian/control
	packages/lnv/debian/install
	packages/lnv/debian/lnv-dsr.init
	packages/lnv/debian/lnv-pdd.init
	packages/lnv/debian/postinst
	packages/lnv/lnv-dsr
	packages/lnv/lnv-pdd
	packages/lnv/lnv.conf
	packages/lnv/lnv/common.py
	packages/lnv/lnv/config.py
	packages/ptm/debian/ptmd.install
	patches/bcm-sdk/series
	patches/bridge-utils/remove-ifupdown-support.patch
	patches/ethtool/force-speed-and-duplex-setting.patch
	patches/ethtool/series
	patches/iproute/series
	patches/iproute/update-neighbour-h-to-latest-upstream.patch
	patches/kernel/arch-intel-centerton-reboot-cf9.patch
	patches/kernel/debian-cumulus-controlfiles.patch
	patches/kernel/driver-hwmon-max6620-fix-rpm-calc.patch
	patches/kernel/driver-hwmon-pmbus-dni_dps460.patch
	patches/kernel/driver-support-intel-avoton-ethernet-with-broadcom-phy.patch
	patches/kernel/network-bridge-igmp-fast-leave.patch
	patches/kernel/network-bridge-igmpv3.patch
	patches/kernel/network-bridge-querier-ifaddr.patch
	patches/kernel/network-bridge-use-spin_lock_bh-from-process-context.patch
	patches/kernel/network-ipv6-route-fix-multipath-duplicate-nexthops.patch
	patches/kernel/network-tun-ethtool.patch
	patches/kernel/series
	patches/libnl/series
	patches/lldpd/add-rport-notification-on-linkdown.patch
	patches/lldpd/series
	patches/monit/cumulus-monitrc.patch
	patches/monit/series
	patches/quagga/bgp-interface-config.patch
	patches/quagga/bgpd-anvl-aggregate-failures.patch
	patches/quagga/bgpd-as-override.patch
	patches/quagga/bgpd-atomic-aggregate-missing.patch
	patches/quagga/bgpd-connected-nht.patch
	patches/quagga/bgpd-establish-peers-faster.patch
	patches/quagga/bgpd-event-driven-route-map-updates.patch
	patches/quagga/bgpd-fsm-fix.patch
	patches/quagga/bgpd-gr-route-selection-fix.patch
	patches/quagga/bgpd-maxmed-administrative-onstartup.patch
	patches/quagga/bgpd-pfxrcd-include-unuseable.patch
	patches/quagga/bgpd-route-map-dry-run.patch
	patches/quagga/bgpd-route-map-match-interface.patch
	patches/quagga/bgpd-rr-allow-policy-outbound.patch
	patches/quagga/bgpd-save-last-bad-msg.patch
	patches/quagga/bgpd-scale-update-delay-packing.patch
	patches/quagga/nexthop-tracking.patch
	patches/quagga/ospfd-mi.patch
	patches/quagga/ospfd-p2p-destination-fix.patch
	patches/quagga/ptm-bfd-integration.patch
	patches/quagga/quagga-faster-compile.patch
	patches/quagga/series
	patches/quagga/zebra-client-info-detail.patch
	patches/quagga/zebra-nht-routemap.patch
	patches/quagga/zebra-recursive-route.patch
	patches/quagga/zebra-redistribute-table.patch
	patches/quagga/zebra-route-tags.patch
	patches/quagga/zebra-set-src-routemap.patch
	patches/quagga/zebra-static-route-nht.patch
	rootconf/default/etc/cumulus/switchd.conf
	rootconf/default/home/cumulus/sysroot-complete
	rootconf/default/home/cumulus/sysroot-config
	switchd/hal.c
	switchd/hal.h
	switchd/hal_acl_bcm.c
	switchd/hal_bcm.c
	switchd/hal_bcm.h
	switchd/hal_bcm_vxlan.c
	switchd/hal_dummy.c
	switchd/hal_int.h
	switchd/hal_util.c
	switchd/netlink.c
	switchd/switchd.c
	switchd/sync.c
	tests/config/__init__.py
	tests/config/default.cfg
	tests/data/specs/bgp_stress.py
	tests/examples/testssim2.py
	tests/infra/testssim2.py
	tests/l2/l2_lldp_test.py
	tests/l3/bgp_alpm_test.py
	tests/l3/bgp_msft_fastreboot_test.py
	tests/l3/bgp_scale_amzn_test.py
	tests/l3/bgp_smoke_test.py
	tests/l3/bgp_v4_v6.py
	tests/l3/l3_helper.py
	tests/l3/traffic_utils.py
	tests/l3/zebra_test.py
	tests/lib/decorators.py
	tests/platform/cl-img.py
	tests/smoke/testcommands.py
	tests/smoke/testifupdown2.py
	tests/smoke/testneighborcheck.py
	tests/smoke/testroutecheck.py
	tests/smoke/testroutes2.py
	tests/tests/examples/testssim2.py
	utilities/distro-cmd
	utilities/packages/autolib/fs.py
	utilities/packages/autolib/netobjects.py
	utilities/packages/autolib/scripts/watch.py
	utilities/packages/autolib/timeout.py
	utilities/packages/ssim2/net.py
	utilities/packages/ssim2/scripts/nodecom.py
	utilities/packages/ssim2/simlib.py
	utilities/packages/ssim2/spec.py
	utilities/packages/ssim2/templates/interfaces.tmpl
	utilities/packages/testfu/buildout.cfg
	utilities/packages/testfu/scripts/runteststmpl.sh
	utilities/packages/testfu/scripts/xmltoresults.py
 2014-08-24 18:39:31 -07:00
Wilson Kok
45aa75e895 Revert "log /etc/init.d/networking errors into syslog using /usr/bin/logger" 
This reverts commit 99d97bfcd931d40b84387f073a6c1b16866fc1e2.
 2014-07-27 21:28:46 -07:00
Wilson Kok
2e87a5b01a Revert "log /etc/init.d/networking errors into syslog using /usr/bin/logger" 
This reverts commit 99d97bfcd931d40b84387f073a6c1b16866fc1e2.
 2014-07-25 10:33:44 -07:00
Roopa Prabhu
ed7b734945 Remove exclude lo 
Ticket: CM-3300
Reviewed By:
Testing Done: Tested reboot/shutdown and service networking restart
 2014-07-22 15:34:15 -07:00
Roopa Prabhu
904908bc5f Documentation cleanup 
Ticket:
Reviewed By:
Testing Done:

- these changes are mainly related to api doc generation using sphinx
 2014-07-22 11:15:56 -07:00
Roopa Prabhu
2c0ad8b338 Doc updates + cleanup 
Ticket: CM-2297
Reviewed By:
Testing Done: compile tested

more updates coming ...
 2014-07-17 11:44:36 -07:00
Roopa Prabhu
09a304ca24 Fix return value when upperifaces are brought up 
Ticket: CM-3208
Reviewed By:
Testing Done: Tested with testcase listed in the bug

This patch does the following:
- moves the interface error exit check to before upperifaces are brought
  up
- changes errors to warns on upperiface error (this is because
  upperiface 'up' is done as best effort to reconfigure the interface in
  question as slave device to the upper device. But if the upper device
  is not in a right state config steps can fail. And we should just
warn).
- Implicitly bringing up the upperifaces helps in most of the cases. especially
  when a bond is brought down and up. The upperiface handling code adds
  the bond back into bridges it was part of. or creates the vlan devices
  on the bond that got deleted. But there can be cases where upperifaces are
  not in the right state and this results in warnings.

  To disable the implicit upperiface handling, this patch also supports
  'skip_upperifaces=1' in /etc/network/ifupdown2/ifupdown2.conf

in future, i am thinking of an option --skip-upperifaces to ifup
 2014-07-16 14:07:58 -07:00
Roopa Prabhu
3808becfbc log /etc/init.d/networking errors into syslog using /usr/bin/logger 
Ticket: CM-3193
Reviewed By:
Testing Done: Tested logging of errors in syslog from ifup at bootup

Example error msg:
"Jul 10 03:13:17 cumulus /etc/init.d/networking[1183]: error:
/etc/network/interfaces: line16: invalid auto line 'auto'"

This patch logs into syslog only during bootup
 2014-07-16 14:07:49 -07:00
Roopa Prabhu
c25e5b6521 Add a new ifupdown2 example to cover bridge igmp and mstp attributes 
Ticket: CM-1438
Reviewed By: TBD
Testing Done: Tested the example file with ifupdown2
 2014-07-16 14:07:41 -07:00
Roopa Prabhu
ca10586116 Bump kernel ethtool get/set wait to 20 + ifupdown2 convert ethtool 
errors to warns

Ticket: CM-3159
Reviewed By: briefly ran this by jtoppins and andy (sfeldma is on
vacation this week).
Testing Done: tested ifupdown2 with ethtool config during boot (sam will
also be adding the testcase mentioned in the bug to ifupdown2 smoke)

The kernel timeout increase helps right now.
we should revisit this again in 2.3 to close all corner cases.

ifupdown2 will now warn on ethtool errors and will also return
non-zero exit status
 2014-07-16 14:07:31 -07:00
Roopa Prabhu
fffdae9c21 Fix use of args.CLASS with ifreload (reload does not support CLASS yet). 
Ticket: CM-3176
Reviewed By: trivial
Testing Done: Tested ifreload with the testcase in the bug

This broke when i recently fixed --allow-classes support for ifup/ifdown
 2014-07-16 14:07:22 -07:00
Roopa Prabhu
699c1cffee Fix error flag for cases where errors are ignored (part of commit 
3afb698d60a7ec0bb3029efccc82c0bd1aa49197)

Ticket: CM-2960
Reviewed By:
Testing Done: ifupdown2 sanity + precommit
 2014-07-16 14:07:13 -07:00
Roopa Prabhu
5973036bba exit with non-zero return code if any of the ifaces have errors 
Ticket: CM-2960
Reviewed By:
Testing Done: ifupdown2 sanity + error cases + precommit

uses a class variable to store return value
 2014-07-16 14:03:45 -07:00
Roopa Prabhu
f102ef630d Fix splits everywhere to include space and tabs. Use regex split 
Ticket: CM-3121
Reviewed By:
Testing Done: Ran precommit

Conflicts:
	packages/ifupdown2-addons/pkg/modulebase.py
 2014-07-16 13:51:00 -07:00
Roopa Prabhu
5ee3e1a854 Fix handling of interfaces with --allow CLASS 
Ticket: CM-3105
Reviewed By:
Testing Done: precommit and some interface class tests

- the patch mostly involves code reorg
 2014-07-16 12:03:03 -07:00
Roopa Prabhu
ba7b1d6084 Fix scheduler for --allow <classes> option 
Ticket:
Reviewed By: nobody
Testing Done: Tested --allow <classes>
 2014-07-16 12:02:55 -07:00
Roopa Prabhu
c007122552 Fix whitespace issue + uninitialized variable issue 
Ticket: CM-2997
Reviewed By: shm
Testing Done: Ran precommit
 2014-07-16 12:02:47 -07:00
Roopa Prabhu
33e106daff Fix upperiface check when ifdown is run with -a 
Ticket: CM-3007
Reviewed By: shm + patch was pasted in the bug for review
Testing Done: ran precommit + maliks test + malik ran his test on his
box

When -a is specified ifupdown2 works on all interfaces and since the the
upperiface check is a bit expensive i had a "skip" on that.
And so far all the user commands i have seen only work on the $IFACE and
not its dependents. So, never hit this case.
 2014-07-16 12:02:38 -07:00
Roopa Prabhu
1b0b81a23f prefix ethtool attributes with "link-" to be compatible with 
native ifupdown + documentation fixes

Ticket: CM-3000
Reviewed By: trivial + doc related
Testing Done: Ran precommit
 2014-07-16 12:02:31 -07:00
Roopa Prabhu
068a729037 Add close_fds=True in ifupdownbase class 
Ticket: CM-2899
Reviewed By:
Testing Done: Tested ifupdown sanity

Just closing all the places where we could leak fds.
 2014-07-16 12:01:59 -07:00
Roopa Prabhu
7ea57ea91f Fix return value when upperifaces are brought up 
Ticket: CM-3208
Reviewed By:
Testing Done: Tested with testcase listed in the bug

This patch does the following:
- moves the interface error exit check to before upperifaces are brought
  up
- changes errors to warns on upperiface error (this is because
  upperiface 'up' is done as best effort to reconfigure the interface in
  question as slave device to the upper device. But if the upper device
  is not in a right state config steps can fail. And we should just
warn).
- Implicitly bringing up the upperifaces helps in most of the cases. especially
  when a bond is brought down and up. The upperiface handling code adds
  the bond back into bridges it was part of. or creates the vlan devices
  on the bond that got deleted. But there can be cases where upperifaces are
  not in the right state and this results in warnings.

  To disable the implicit upperiface handling, this patch also supports
  'skip_upperifaces=1' in /etc/network/ifupdown2/ifupdown2.conf

in future, i am thinking of an option --skip-upperifaces to ifup
 2014-07-14 22:30:14 -07:00
Roopa Prabhu
0c3c69e020 log /etc/init.d/networking errors into syslog using /usr/bin/logger 
Ticket: CM-3193
Reviewed By:
Testing Done: Tested logging of errors in syslog from ifup at bootup

Example error msg:
"Jul 10 03:13:17 cumulus /etc/init.d/networking[1183]: error:
/etc/network/interfaces: line16: invalid auto line 'auto'"

This patch logs into syslog only during bootup
 2014-07-14 22:30:04 -07:00
Roopa Prabhu
a9ee5e1830 Add a new ifupdown2 example to cover bridge igmp and mstp attributes 
Ticket: CM-1438
Reviewed By: TBD
Testing Done: Tested the example file with ifupdown2
 2014-07-14 22:29:52 -07:00
Roopa Prabhu
df4cba54e2 Bump kernel ethtool get/set wait to 20 + ifupdown2 convert ethtool 
errors to warns

Ticket: CM-3159
Reviewed By: briefly ran this by jtoppins and andy (sfeldma is on
vacation this week).
Testing Done: tested ifupdown2 with ethtool config during boot (sam will
also be adding the testcase mentioned in the bug to ifupdown2 smoke)

The kernel timeout increase helps right now.
we should revisit this again in 2.3 to close all corner cases.

ifupdown2 will now warn on ethtool errors and will also return
non-zero exit status
 2014-07-14 22:29:33 -07:00
Roopa Prabhu
89aa6573d6 Fix use of args.CLASS with ifreload (reload does not support CLASS yet). 
Ticket: CM-3176
Reviewed By: trivial
Testing Done: Tested ifreload with the testcase in the bug

This broke when i recently fixed --allow-classes support for ifup/ifdown
 2014-07-14 22:29:05 -07:00
Roopa Prabhu
0bb5110d65 Fix error flag for cases where errors are ignored (part of commit 
3afb698d60a7ec0bb3029efccc82c0bd1aa49197)

Ticket: CM-2960
Reviewed By:
Testing Done: ifupdown2 sanity + precommit
 2014-07-14 22:28:54 -07:00
Roopa Prabhu
1104a8609e exit with non-zero return code if any of the ifaces have errors 
Ticket: CM-2960
Reviewed By:
Testing Done: ifupdown2 sanity + error cases + precommit

uses a class variable to store return value
 2014-07-14 22:28:44 -07:00