Add a safety cast for 32 bit systems

Fix integer overflow on 32 bit
2024-05-19 06:50:01 +00:00 · 2016-02-27 21:29:33 -08:00 · 2016-02-27 19:34:47 -08:00
1 changed files with 3 additions and 3 deletions
--- a/dpinger.c
+++ b/dpinger.c
@@ -286,7 +286,7 @@ llsqrt(
        }
    }

-    return s;
+    return (unsigned long) s;
 }


@@ -471,7 +471,7 @@ report(
            packets_received++;
            latency_usec = array[slot].latency_usec;
            total_latency_usec += latency_usec;
-            total_latency_usec2 += latency_usec * latency_usec;
+            total_latency_usec2 += (unsigned long long) latency_usec * latency_usec;
        }
        else if (array[slot].status == PACKET_STATUS_SENT &&
                 ts_elapsed_usec(&array[slot].time_sent, &now) > loss_interval_usec)
@@ -489,7 +489,7 @@ report(

        // stddev = sqrt((sum(rtt^2) / packets) - (sum(rtt) / packets)^2)
        *average_latency_usec = avg;
-        *latency_deviation = llsqrt(avg2 - (avg * avg));
+        *latency_deviation = llsqrt(avg2 - ((unsigned long long) avg * avg));
    }
    else
    {
Author	SHA1	Message	Date
Denny Page	fdbd4a1d96	Add a safety cast for 32 bit systems	2016-02-27 21:29:33 -08:00
Denny Page	6796fa0752	Fix integer overflow on 32 bit	2016-02-27 19:34:47 -08:00