mirror/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2024-05-11 05:55:29 +00:00
Code Issues Projects Releases Wiki Activity

New review approvals shouldn't require a message (#8991)

Browse Source 
* New approvals don't require content

Signed-off-by: jolheiser <[email protected]>

* Fix edge-bug

Signed-off-by: jolheiser <[email protected]>
This commit is contained in:
John Olheiser
2019-11-14 20:58:01 +00:00
committed by zeripath
co-authored by zeripath
parent ae36ed7ecb
commit 4b5ebb93e4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
models/review.go
+2 -2
View File
@@ -254,7 +254,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content strin
return nil, nil, err
}
if len(strings.TrimSpace(content)) == 0 {
if reviewType != ReviewTypeApprove && len(strings.TrimSpace(content)) == 0 {
return nil, nil, ContentEmptyErr{}
}
@@ -272,7 +272,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content strin
if err := review.loadCodeComments(sess); err != nil {
return nil, nil, err
}
if len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
if reviewType != ReviewTypeApprove && len(review.CodeComments) == 0 && len(strings.TrimSpace(content)) == 0 {
return nil, nil, ContentEmptyErr{}
}