Commit Graph
8715 Commits
Author SHA1 Message Date
silverwindandtechknowlogick 3e23dad075 fix webpack polyfills (#9735) (#9738)
webpack polyfills did not work because useBuiltIns: 'entry' expects a
explicit core-js import. Changed it to 'usage' which does not require
these explicit imports and polyfills based on browserslist.

As a result, the built index.js now went from 128kB to 192kB.

Ref: https://babeljs.io/docs/en/babel-preset-env#usebuiltins
2020-01-12 17:43:16 -05:00
b13b9d3dbd Move Errored PRs out of StatusChecking (#9675) (#9726)
* Move Errored PRs out of StatusChecking (#9675)

* Set Errored PRs out of StatusChecking

* Ensure that api status is correctly set too

* Update models/pull.go

Co-Authored-By: John Olheiser <[email protected]>

Co-authored-by: John Olheiser <[email protected]>

* Update services/pull/check.go

Co-authored-by: John Olheiser <[email protected]>
2020-01-12 20:52:40 +01:00
4072f28e60 Make hook status printing configurable with delay (#9641) (#9725)
* Delay printing hook statuses until after 1 second

* Move to a 5s delay, wrapped writer structure and add config

* Update cmd/hook.go

* Apply suggestions from code review

* Update cmd/hook.go

Co-authored-by: Antoine GIRARD <[email protected]>

Co-authored-by: Antoine GIRARD <[email protected]>
2020-01-12 18:02:36 +00:00
dbeef6bb02 [BugFix] [API] ​/repos​/issues​/search (#9698) (#9724)
* fix

* fix options

* add TEST

Co-authored-by: Antoine GIRARD <[email protected]>

Co-authored-by: Antoine GIRARD <[email protected]>
2020-01-12 10:20:49 +00:00
silverwindandtechknowlogick fec35440db silence fomantic error regarding tabs (#9713) (#9718)
Fomantic expects all tabs to have a target element with content as
defined by the data-tab attribute. All our usage of the tab module seems
to use <a> element tabs that link to new pages so these content elements
are never present and fomantic complains about that in the console with
an "Activated tab cannot be found" error. This silences that error.
2020-01-11 23:20:33 -05:00
zeripathandGitHub f8ea50cc7a Remove unused lock (#9710) 2020-01-11 19:06:39 +00:00
zeripathandGitHub 0e53a16cca Missed q.lock.Unlock() will cause panic (#9706) 2020-01-11 17:05:24 +00:00
zeripathandLauris BH 7eaba6ba8a Never allow an empty password to validate (#9682) (#9683)
* Restore IsPasswordSet previous value

* Update models/user.go

Co-authored-by: Lauris BH <[email protected]>
2020-01-11 16:27:03 +02:00
guillep2kandtechknowlogick ff16099c6d Don't attempt to close issue if already closed (#9699) 2020-01-11 01:42:11 -05:00
John Olheiserandtechknowlogick a516a7ba0f Load milestone in API PR list (#9671) (#9700) 2020-01-10 22:58:03 -05:00
11bce6fd3d eliminate horizontal scroll caused by footer (#9674)
Co-authored-by: zeripath <[email protected]>
2020-01-10 08:45:59 +08:00
techknowlogickandGitHub 3fb906dc02 remove google font call (#9668) (#9681) 2020-01-09 16:40:57 -05:00
zeripathandtechknowlogick 3a00a690c9 Prevent redirect to Host (#9678) (#9679) 2020-01-09 16:37:37 -05:00
John Olheiserandzeripath a2b7cc1bb1 Fix nil reference in repo generation (#9660) (#9666)
* Fix nil reference

Signed-off-by: jolheiser <[email protected]>

* Tighten

Signed-off-by: jolheiser <[email protected]>
2020-01-09 16:50:21 +00:00
John OlheiserandLauris BH 04a77b1f42 Add HTML URL to API Issues (#9654) (#9661)
* Add HTML URL to API Issues

Signed-off-by: jolheiser <[email protected]>

* Swagger

Signed-off-by: jolheiser <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
2020-01-09 08:07:21 +02:00
f523372d07 Add PR review webhook to Telegram (#9653) (#9655)
Signed-off-by: jolheiser <[email protected]>

Co-authored-by: Antoine GIRARD <[email protected]>

Co-authored-by: Antoine GIRARD <[email protected]>
2020-01-08 21:42:28 +02:00
6543andAntoine GIRARD e39c238ef4 fix #9648 (#9652) 2020-01-08 17:32:25 +01:00
bb4476908d Changelog for 1.11.0-RC1 (#9636)
* generated Changelog

* cormat, sort, fix

* teamwork :)

Co-Authored-By: techknowlogick <[email protected]>
Co-Authored-By: guillep2k <[email protected]>
Co-Authored-By: John Olheiser <[email protected]>

* next()

* Next()

* add last change

* as @jolheiser suggested

* Apply suggestions from code review

Co-Authored-By: techknowlogick <[email protected]>

* Apply suggestions from code review

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-Authored-By: John Olheiser <[email protected]>

* Update CHANGELOG.md

Co-Authored-By: guillep2k <[email protected]>

* add bugfix + topic is plural

* rest

* Apply suggestions from code review

* Apply suggestions from code review

Co-Authored-By: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: guillep2k <[email protected]>
Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: zeripath <[email protected]>
v1.11.0-rc1
2020-01-08 10:57:44 +08:00
c181070f9e Repository teams - disable remove button when have access to all (#9640)
Co-authored-by: zeripath <[email protected]>
2020-01-08 08:36:39 +08:00
Shashvat Kediaandzeripath 1e9b3d4743 Fix #9530: admin auth list make readable and admin auth delete bug fix (#9628) 2020-01-07 23:41:16 +00:00
Lunny Xiaoandzeripath b9309e52f0 Move wiki related funtions from models to services/wiki (#9355)
* Move wiki related funtions from models to services/wiki
2020-01-07 18:27:36 +00:00
zeripathandGitHub e5d8e2d10c Branches not at ref commit ID should not be listed as Merged (#9614)
Once a branch has been merged if the commit ID no longer equals that of
the pulls ref commit id don't offer to delete the branch on the pull screen
and don't list it as merged on branches.

Fix #9201

When looking at the pull page we should also get the commits from the refs/pulls/x/head

Fix #9158
2020-01-07 17:06:14 +00:00
6543andzeripath 9406368633 Fix Issue Unsubscription (#9634) 2020-01-07 15:41:35 +00:00
GiteaBot b6fa229dcf [skip ci] Updated translations via Crowdin 2020-01-07 14:32:33 +00:00
zeripathandGitHub 0d515474b8 Remove stray printf (#9631) 2020-01-07 14:30:03 +00:00
GiteaBot c88f0fed36 [skip ci] Updated translations via Crowdin 2020-01-07 11:24:19 +00:00
62eb1b0f25 Graceful Queues: Issue Indexing and Tasks (#9363)
* Queue: Add generic graceful queues with settings

* Queue & Setting: Add worker pool implementation

* Queue: Add worker settings

* Queue: Make resizing worker pools

* Queue: Add name variable to queues

* Queue: Add monitoring

* Queue: Improve logging

* Issues: Gracefulise the issues indexer

Remove the old now unused specific queues

* Task: Move to generic queue and gracefulise

* Issues: Standardise the issues indexer queue settings

* Fix test

* Queue: Allow Redis to connect to unix

* Prevent deadlock during early shutdown of issue indexer

* Add MaxWorker settings to queues

* Merge branch 'master' into graceful-queues

* Update modules/indexer/issues/indexer.go

Co-Authored-By: guillep2k <[email protected]>

* Update modules/indexer/issues/indexer.go

Co-Authored-By: guillep2k <[email protected]>

* Update modules/queue/queue_channel.go

Co-Authored-By: guillep2k <[email protected]>

* Update modules/queue/queue_disk.go

* Update modules/queue/queue_disk_channel.go

Co-Authored-By: guillep2k <[email protected]>

* Rename queue.Description to queue.ManagedQueue as per @guillep2k

* Cancel pool workers when removed

* Remove dependency on queue from setting

* Update modules/queue/queue_redis.go

Co-Authored-By: guillep2k <[email protected]>

* As per @guillep2k add mutex locks on shutdown/terminate

* move unlocking out of setInternal

* Add warning if number of workers < 0

* Small changes as per @guillep2k

* No redis host specified not found

* Clean up documentation for queues

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

* Update modules/indexer/issues/indexer_test.go

* Ensure that persistable channel queue is added to manager

* Rename QUEUE_NAME REDIS_QUEUE_NAME

* Revert "Rename QUEUE_NAME REDIS_QUEUE_NAME"

This reverts commit 1f83b4fc9b.

Co-authored-by: guillep2k <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
2020-01-07 12:23:09 +01:00
GiteaBot f71e1c8e79 [skip ci] Updated translations via Crowdin 2020-01-07 07:40:50 +00:00
8ctopusandzeripath 143f88d975 More extensive robots.txt docs (#9566) 2020-01-07 07:38:22 +00:00
GiteaBot 5749b26cdd [skip ci] Updated translations via Crowdin 2020-01-06 16:52:05 +00:00
Timon EngelkeandAntoine GIRARD abc0f53539 Add a /user/login landing page option (#9622)
* Add a /user/login landing page option

* Add test case for login landing page
2020-01-06 17:50:44 +01:00
6543andLauris BH bcac7cb934 fix swagger description of reaction API (#9617) 2020-01-06 06:58:13 +02:00
zeripathandGitHub 2a1cf5bae9 Add some padding to the shadowed comment box (#9612)
* Add some padding to the shadowed comment box
* prevent the padding affecting the other comments
2020-01-05 19:25:27 +00:00
6543andzeripath 133ae18b61 [BugFix] Hide public repos owned by private orgs (#9609)
* Restrict AllPublic to actually public repos.
* Add new parameter to add in AllLimited Repos
2020-01-05 18:48:47 +00:00
7e4f490482 [Docs] introduce "make help" (#9604)
* introduce "make help"

* fix + add more routienes

* Update Makefile

* add make vet

Co-authored-by: techknowlogick <[email protected]>
2020-01-05 12:40:02 -05:00
GiteaBot 444c3a1184 [skip ci] Updated translations via Crowdin 2020-01-05 14:30:20 +00:00
6543andAntoine GIRARD a5a79f702d update gitea.com/macaron/macaron to 1.4.0 (#9608) 2020-01-05 15:27:25 +01:00
John OlheiserandLauris BH 4f54a4628a !important makes me sad (#9607)
Signed-off-by: jolheiser <[email protected]>
2020-01-05 06:56:06 +02:00
John Olheiserandtechknowlogick 08424648ae Fix create bugs (#9606)
Signed-off-by: jolheiser <[email protected]>
2020-01-04 21:39:14 -05:00
David Svantessonandtechknowlogick 03d59bcd1d Fix access issues on milestone and issue overview pages. (#9603)
* Fix access issues on milestone and issue overview pages.

* Fix filter algorithm
2020-01-04 20:23:29 -05:00
Antoine GIRARDandLauris BH 8b24073713 Only serve attachments when linked to issue/release and if accessible by user (#9340)
* test: add current attachement responses

* refactor: check if attachement is linked and accessible by user

* chore: clean TODO

* fix: typo attachement -> attachment

* revert un-needed go.sum change

* refactor: move models logic to models

* fix TestCreateIssueAttachment which was wrongly successful

* fix unit tests with unittype added

* fix unit tests with changes

* use a valid uuid format for pgsql int. test

* test: add unit test TestLinkedRepository

* refactor: allow uploader to access unlinked attachement

* add missing blank line

* refactor: move to a separate function repo.GetAttachment

* typo

* test: remove err test return

* refactor: use repo perm for access checking generally + 404 for all reject
2020-01-05 01:20:08 +02:00
GiteaBot 6a5a2f493a [skip ci] Updated translations via Crowdin 2020-01-04 22:21:24 +00:00
John Olheiserandzeripath fb3a6aba7d Only show sender if it makes sense (#9601)
Signed-off-by: jolheiser <[email protected]>
2020-01-04 22:20:15 +00:00
GiteaBot 07439d8059 [skip ci] Updated translations via Crowdin 2020-01-04 20:29:45 +00:00
Lauris BHandzeripath 2b8b0f66ed Add translatable Powered by Gitea text in footer (#9600) 2020-01-04 20:27:19 +00:00
ee9b9365be [Docs] Add guide on howto develop API (#9587)
* draft 1

* add suggestions
thanks to @bagasme @techknowlogick @davidsvantesson

* http methods

* use permalinks

* Apply suggestions from code review

Co-Authored-By: John Olheiser <[email protected]>

* Apply suggestions from code review

Co-Authored-By: John Olheiser <[email protected]>

* code format + add to INDEX

Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2020-01-04 10:23:40 +08:00
bedd7b2833 Fix error logged when repos qs is empty (#9591)
* Fix error logged when repos qs is empty

* Update routers/user/home.go

Co-Authored-By: Lauris BH <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2020-01-03 23:39:12 +02:00
GiteaBot 4a768e1c3e [skip ci] Updated translations via Crowdin 2020-01-03 18:44:08 +00:00
34c5eee703 Add footer extra links template (#9576)
* Add footer extra links template

* [Docs] Update to mention extra links footer template

* Commit suggestion from @davidsvantesson

Co-Authored-By: David Svantesson <[email protected]>

* Move template placement to right side of footer

Co-authored-by: David Svantesson <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2020-01-03 20:41:56 +02:00
ea707f5a77 Add branch protection option to block merge on requested changes. (#9592)
* Add branch protection option to block merge on requested changes.

* Add migration step

* Fix check to correct negation

* Apply suggestions from code review

Language improvement.

Co-Authored-By: John Olheiser <[email protected]>

* Copyright year.

Co-authored-by: John Olheiser <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
2020-01-03 19:47:09 +02:00