60b51d0648
Show error toast when file size exceeds the limits ( #27985 ) ( #27986 )
...
Backport #27985 by @lng2020
As title.
Before that, there was no alert at all.
After:
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-11-10 11:52:04 +00:00
824d40edc6
Fix citation error when the file size is larger than 1024 bytes ( #27958 ) ( #27965 )
...
Backport #27958 by @yp05327
Mentioned in:
https://github.com/go-gitea/gitea/pull/27931#issuecomment-1798016960
Same to #25131 , so use the same method to fix this problem.
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-08 22:45:57 +08:00
46ac04ce9d
Add word-break to repo description in home page ( #27924 ) ( #27957 )
...
Backport #27924 by @yp05327
In #25315 , @denyskon fixed UI on mobile view.
But for the repo description, on desktop view there's no word-break.
So maybe we can just add `gt-word-break` to fix it on both mobile view
and desktop view.
Before:
desktop view:
mobile view:
After:
desktop view:
mobile view(almost same?)
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-11-08 01:29:33 +00:00
cc7b9eb085
Document REACTION_MAX_USER_NUM setting option ( #27954 ) ( #27959 )
...
Backport #27954 by @6543
as title
---
*Sponsored by Kithara Software GmbH*
Co-authored-by: 6543 <m.huber@kithara.com >
2023-11-08 08:54:48 +08:00
7aafe5e0b4
Fix rendering assignee changed comments without assignee ( #27927 ) ( #27952 )
...
Backport #27927 by @invliD
When an assignee changed event comment is rendered, most of it is
guarded behind the assignee ID not being 0. However, if it is 0, that
results in quite broken rendering for that comment and the next one.
This can happen, for example, when repository data imported from outside
of Gitea is incomplete.
This PR makes sure comments with an assignee ID of 0 are not rendered at
all.
---
Screenshot before:
<img width="272" alt="Bildschirmfoto 2023-11-05 um 20 12 18"
src="https://github.com/go-gitea/gitea/assets/42910/7d629d76-fee4-4fe5-9e3a-bf524050cead ">
The comments in this screenshot are:
1. A regular text comment
2. A user being unassigned
3. A user being assigned
4. The title of the PR being changed
Comments 2 and 3 are rendered without any text, which indents the next
comment and does not leave enough vertical space.
Co-authored-by: Sebastian Brückner <code@nik.dev >
2023-11-07 22:02:36 +01:00
9e15955c68
Add word break to release title ( #27942 ) ( #27947 )
...
Backport #27942 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-07 20:30:51 +08:00
6eadad8222
Update environment-to-ini flag parsing ( #27914 ) ( #27940 )
...
Backport #27914 by @fashberg
This Fixes #27913
This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2
Doc: <https://cli.urfave.org/v2/examples/combining-short-options/ >
Co-authored-by: Folke <folke@ashberg.de >
2023-11-06 21:10:10 +00:00
a8e505a44b
Unify two factor check ( #27915 ) ( #27929 )
...
Backport #27915 by @KN4CK3R
Fixes #27819
We have support for two factor logins with the normal web login and with
basic auth. For basic auth the two factor check was implemented at three
different places and you need to know that this check is necessary. This
PR moves the check into the basic auth itself.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-11-06 18:07:22 +00:00
e47b31c691
Remove known issue section in Gitea Actions Doc ( #27930 ) ( #27938 )
...
Backport #27930 by @lng2020
The bug has been fixed for several months in the
`docker/build-push-action`
The fix commit is
[d8823bfaed](d8823bfaed70063547+lng2020@users.noreply.github.com >
2023-11-06 17:03:06 +01:00
49f82ac4e3
Fix JS NPE when viewing specific range of PR commits ( #27912 ) ( #27923 )
...
Backport #27912 by @delvh
This should be the easiest fix.
While other solutions might be possible that exterminate the root cause,
they will not be as trivial.
Co-authored-by: delvh <dev.lh@web.de >
2023-11-06 09:22:44 +00:00
81d233d987
Install poetry dependencies with --no-root ( #27919 ) ( #27920 )
...
Backport #27919 by @silverwind
Poetry 1.7.0 or higher will print a warning otherwise, see discussions:
https://github.com/python-poetry/poetry/pull/8369
https://github.com/python-poetry/poetry/issues/1132
> --no-root Do not install the root package (the current project).
Co-authored-by: silverwind <me@silverwind.io >
2023-11-06 02:14:46 +00:00
2f56ab7999
Show correct commit sha when viewing single commit diff ( #27916 ) ( #27921 )
...
Backport #27916 by @sebastian-sauer
Show the correct sha when viewing a single commit.
Co-authored-by: sebastian-sauer <sauer.sebastian@gmail.com >
2023-11-06 09:09:35 +08:00
61d3d9205b
Fix 500 when deleting a dismissed review ( #27903 ) ( #27910 )
...
Backport #27903 by @lng2020
Fix #27767
Add a test to ensure its behavior
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-11-05 13:59:11 +00:00
28e3d0b0d3
Remove action runners on user deletion ( #27902 ) ( #27908 )
...
Backport #27902 by @earl-warren
- On user deletion, delete action runners that the user has created.
- Add a database consistency check to remove action runners that have
nonexistent belonging owner.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1720
(cherry picked from commit 009ca7223dab054f7f760b7ccae69e745eebfabb)
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
2023-11-05 13:20:00 +00:00
4c67c05480
Backport translations to v1.21 ( #27899 )
...
I manually fixed most of the files so that used translation keys don't
get deleted.
2023-11-04 20:33:38 +08:00
cf7374c079
Remove set tabindex on view issue ( #27892 ) ( #27896 )
...
Backport #27892 by @earl-warren
- Remove the set tabindex and instead let the browser figure out the
correct tab order.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1626
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-03 23:25:11 +08:00
8d0a4d7e9d
Fix DownloadFunc when migrating releases ( #27887 ) ( #27890 )
...
Backport #27887 by @Zettat123
We should not use `asset.ID` in DownloadFunc because DownloadFunc is a
closure.
1bf5527eac/services/migrations/gitea_downloader.go (L284-L295)#14703 . This
PR fixes the bug when migrating from Gitea and GitLab.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-11-03 08:29:30 +00:00
9ca1853495
Fix http protocol auth ( #27875 ) ( #27876 )
...
Backport #27875 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-11-02 16:34:55 +01:00
d6f7c49b8b
Reduce margin/padding on flex-list items and divider ( #27872 ) ( #27874 )
...
Backport #27872 by @silverwind
Small CSS tweak, reduces margin/padding from 14px to 10px, which I think
looks better
2023-11-02 13:24:03 +08:00
c074af6a6d
refactor postgres connection string building ( #27723 ) ( #27869 )
...
Backport #27723 by @mpldr
This patchset changes the connection string builder to use net.URL and
the host/port parser to use the stdlib function for splitting host from
port. It also adds a footnote about a potentially required portnumber
for postgres UNIX sockets.
Fixes : #24552
Co-authored-by: Moritz Poldrack <33086936+mpldr@users.noreply.github.com >
2023-11-01 23:19:02 +00:00
39596115da
Change katex limits ( #27823 ) ( #27868 )
...
Backport #27823 by @KN4CK3R
Fixes #27812
Use higher defaults again but limit the input size.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-11-01 22:26:45 +01:00
352906b448
doc: actions/act-runner: document running as a systemd service ( #27844 ) ( #27866 )
...
Backport #27844 by @nodiscc
This documents running `act-runner` as a systemd service under a
dedicated user account.
Co-authored-by: nodiscc <nodiscc@gmail.com >
2023-11-01 18:18:01 +01:00
6637bbf510
Delete repos of org when purge delete user ( #27273 ) ( #27728 )
...
Fixes https://codeberg.org/forgejo/forgejo/issues/1514
Backports #27273
---------
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-11-01 10:03:12 +08:00
6ac2ade97d
Clean up template locale usage ( #27856 ) ( #27857 )
...
Backport #27856
The only conflict is `ThemeName` in `500.tmpl`, it has been resolved
manually by keeping using old
`{{.SignedUser.Theme}}{{else}}{{DefaultTheme}}`
2023-10-31 17:35:55 +01:00
18a782f73d
Fix package webhook ( #27839 ) ( #27855 )
...
Backport #27839 by @lunny
Fix #23742
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-10-31 11:26:28 +01:00
6af6f81780
Add user secrets API integration tests ( #27832 ) ( #27852 )
...
Backport #27832 by @jbgomond
Adds the missing user secrets API integration tests so #27829 does not
happen again
Co-authored-by: Jean-Baptiste Gomond <dev@jbgomond.com >
2023-10-31 04:14:04 +00:00
d282f5dab8
Fix wrong relative path on obtain token from command line ( #27850 ) ( #27851 )
...
Backport #27850 by @lunny
Caused by #27845
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-10-31 11:36:22 +08:00
f3f56d570b
doc: actions/act-runner: document obtaining a runner registration token from gitea CLI ( #27845 ) ( #27848 )
2023-10-30 20:16:05 -04:00
3c03b7db50
Fix/upload artifact error windows ( #27802 ) ( #27840 )
2023-10-30 11:57:48 +00:00
ac22116211
Always use whole user name as link ( #27815 ) ( #27838 )
...
Backport #27815 by @denyskon
Starting from #25790 this shared template only linked the username of
the user if both display name and username were shown. I experienced
myself always trying to click on the display name - I think it is
annoying for others too.
After:
Co-authored-by: Denys Konovalov <kontakt@denyskon.de >
2023-10-30 12:25:40 +01:00
25bc3d562a
Fix bad method call when deleting user secrets via API ( #27829 ) ( #27831 )
...
Backport #27829 by @jbgomond
Fixed a little mistake when you deleting user secrets via the API. Found
it when working on #27725 .
It should be backported to 1.21 I think.
Co-authored-by: Jean-Baptiste Gomond <dev@jbgomond.com >
2023-10-29 22:08:01 +08:00
991c959110
Dockerfile small refactor ( #27757 ) ( #27826 )
...
Backport #27757 by @nfsec
- Size and layer optimization,
- Maintaining consistency in definitions (comments, apk etc.),
Co-authored-by: Patryk Krawaczyński <nfsec@users.noreply.github.com >
2023-10-29 13:20:54 +01:00
2d2a5657ef
Upgrade xorm to 1.3.4 ( #27807 ) ( #27813 )
...
Backport #27807 by @lng2020
Noticeable change:
Remove the `OrderBy("1") `
[patch](https://github.com/go-gitea/gitea/pull/27673#issuecomment-1768570142 )
for mssql since xorm has [fixed
it](0f085408af70063547+lng2020@users.noreply.github.com >
2023-10-27 14:17:27 +02:00
977f5db28e
Chroma v2.10.0 ( #27803 ) ( #27805 )
...
Backport #27803 by @bt90
Bump the chroma version to v2.10.0:
https://github.com/alecthomas/chroma/releases/tag/v2.10.0
This release includes a better Java lexer
https://github.com/alecthomas/chroma/pull/873
Co-authored-by: bt90 <btom1990@googlemail.com >
2023-10-27 13:25:25 +02:00
487c573c28
Add dedicated class for empty placeholders ( #27788 ) ( #27792 )
...
Backport #27788 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/27784
<img width="1033" alt="Screenshot 2023-10-25 at 19 07 15"
src="https://github.com/go-gitea/gitea/assets/115237/1a363851-1a86-48cb-99ec-0a573371bb6e ">
<img width="1051" alt="Screenshot 2023-10-25 at 19 07 41"
src="https://github.com/go-gitea/gitea/assets/115237/add4b606-2264-430a-af35-249ef005817f ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-10-26 09:26:05 +02:00
25acbfed36
Close all hashed buffers ( #27787 ) ( #27790 )
...
Backport #27787 by @KN4CK3R
Add missing `.Close()` calls. The current code does not delete the
temporary files if the data grows over 32mb.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-10-25 22:24:25 +02:00
9dd8f34707
Add gap between diff boxes ( #27776 ) ( #27781 )
...
Backport #27776 by @silverwind
Before (almost no gap between files):
<img width="1240" alt="Screenshot 2023-10-24 at 19 43 32"
src="https://github.com/go-gitea/gitea/assets/115237/30cdbdbc-d102-479c-89ce-3f68837ae0cd ">
After (with 8px gap):
<img width="1241" alt="Screenshot 2023-10-24 at 19 43 22"
src="https://github.com/go-gitea/gitea/assets/115237/72b26a30-8730-4a36-8de9-be143b684b98 ">
Co-authored-by: silverwind <me@silverwind.io >
2023-10-25 09:09:08 +08:00
77bd3acb65
Do not force creation of _cargo-index repo on publish ( #27266 ) ( #27765 )
...
Backport #27266 by @merlleu
Hello there,
Cargo Index over HTTP is now prefered over git for package updates: we
should not force users who do not need the GIT repo to have the repo
created/updated on each publish (it can still be created in the packages
settings).
The current behavior when publishing is to check if the repo exist and
create it on the fly if not, then update it's content.
Cargo HTTP Index does not rely on the repo itself so this will be
useless for everyone not using the git protocol for cargo registry.
This PR only disable the creation on the fly of the repo when publishing
a crate.
This is linked to #26844 (error 500 when trying to publish a crate if
user is missing write access to the repo) because it's now optional.
Co-authored-by: merlleu <r.langdorph@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-10-24 15:40:02 +08:00
95db95ef91
Fix incorrect "tab" parameter for repo search sub-template ( #27755 ) ( #27764 )
...
Backport #27755 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-10-24 11:01:26 +08:00
ffab2b7e4f
fix issues in translation file ( #27699 ) ( #27737 )
...
Backport #27699
- use correct comment sign for INI (`;`)
- remove duplicated `repo.branch.search` key
- remove duplicated spaces & similar
2023-10-24 01:53:01 +00:00
cb9e10f971
Fix label render containing invalid HTML ( #27752 ) ( #27762 )
...
Backport #27752 by @earl-warren
- The label HTML contained a quote that wasn't being closed.
Refs: https://codeberg.org/forgejo/forgejo/pulls/1651
(cherry picked from commit e2bc2c9a1fff482c49dbeb3a51e4e1c698bf506c)
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
2023-10-24 09:39:13 +08:00
5087de1a5c
Fix link-action redirect network error ( #27734 ) ( #27749 )
...
Backport #27734 by @lng2020
<img width="823" alt="image"
src="https://github.com/go-gitea/gitea/assets/70063547/99da3d5a-c28a-4fd0-8ae0-88461a9142e2 ">
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
Co-authored-by: 6543 <6543@obermui.de >
2023-10-23 13:52:30 +00:00
f2bac791db
Fix duplicate project board when hitting enter key ( #27746 ) ( #27751 )
...
Backport #27746 by @lng2020
When hitting the `enter` key to create a new project column, the request
is sent twice because the `submit` event and `key up` event are both
triggered.
Probably a better solution is to rewrite these parts of the code to
avoid using native jQuery but reuse the `form-fetch-action` class. But
it's beyond my ability.
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-10-23 13:04:53 +00:00
c279f8aab7
Fix incorrect ctx usage in defer function ( #27740 ) ( #27741 )
2023-10-22 14:36:49 +00:00
9f2b8c7ead
fix labeler config on release/v1.21 ( #27738 )
...
Manual backport of #27525
2023-10-22 13:53:34 +00:00
48e3aec862
Enable followCursor for language stats bar ( #27713 ) ( #27739 )
...
Backport #27713 by @silverwind
Fixes: https://github.com/go-gitea/gitea/issues/27600
Also tested together with https://github.com/go-gitea/gitea/pull/27704 ,
works well.
Co-authored-by: silverwind <me@silverwind.io >
2023-10-22 15:35:58 +02:00
aabcf2d7ad
Add doctor dbconsistency fix to delete repos with no owner ( #27290 ) ( #27693 )
...
Backport #27290
2023-10-22 02:21:41 +02:00
6919a02ab7
Fix org team endpoint ( #27721 ) ( #27727 )
...
Backport #27721 by @lng2020
Fix #27711
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-10-22 00:07:28 +00:00
1848858a1e
Feed UI Improvements ( #27356 ) ( #27717 )
...
Backport #27356 by @silverwind
Various improvements related to feeds:
- Fix markdown rendering
- Increase font size from 13px to default 14px via `flex-item`
- Add style to hashes
- Move the timestamp to title line. I realize it's not optimal for
translation, we may need to change all these translations
Before:
<img width="768" alt="Screenshot 2023-09-29 at 22 52 58"
src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c ">
After:
<img width="781" alt="Screenshot 2023-09-29 at 22 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8 ">
Co-authored-by: silverwind <me@silverwind.io >
2023-10-21 11:13:15 +00:00
a398089301
Improve diff tree spacing ( #27714 ) ( #27719 )
...
Backport #27714 by @silverwind
1. Un-indent top-level items, matching GitHub rendering
2. Increase item padding and add 1px gap between items
Before and After:
<img width="247" alt="Screenshot 2023-10-20 at 18 37 32"
src="https://github.com/go-gitea/gitea/assets/115237/43c1ce86-1814-4a8a-9dd2-0c4a82a2be7c ">
<img width="241" alt="Screenshot 2023-10-20 at 18 40 46"
src="https://github.com/go-gitea/gitea/assets/115237/b541b85b-c428-4903-becd-773ae5807495 ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: 6543 <m.huber@kithara.com >
2023-10-21 10:44:58 +00:00
