* Allow token as authorization for accessing attachments
Signed-off-by: David Svantesson <[email protected]>
* Only allow token authentication for attachments if it is a download (GET)
RenderCommitMessageLink may have the
potential for issues and is overall
not very intuitive for the user in its
current state.
This commit will revert the usage
of RenderCommitMessageLink that was
added in #7659 to work on addressing
some of those issues to and merge this
feature again in a more polished state.
Signed-off-by: Gary Kim <[email protected]>
* Provide links in commit summaries in commits table/view list
Signed-off-by: Gary Kim <[email protected]>
* Check that hashes are commits before making them links
Signed-off-by: Gary Kim <[email protected]>
* Revert "Check that hashes are commits before making them links"
This reverts commit a88564b8bc.
* Add Commit Message Links to Files List
Signed-off-by: Gary Kim <[email protected]>
* detect csv delimiter in csv rendering
fixes#7868
* make linter happy
* fix failing testcase & use ints where possible
* expose markup type to template
previously all markup had the .markdown class, which is incorrect,
as it applies markdown CSS & JS logic to CSV rendering
* fix build (missing `make css`)
* ignore quoted csv content for delimiter scoring
also fix html generation
* display ui time with customize time location
* fix lint
* rename UILocation to DefaultUILocation
* move time related functions to modules/timeutil
* fix tests
* fix tests
* fix build
* fix swagger
* Convert files to utf-8 for indexing
* Move utf8 functions to modules/base
* Bump repoIndexerLatestVersion to 3
* Add tests for base/encoding.go
* Changes to pass gosimple
* Move UTF8 funcs into new modules/charset package
* Check commit message hashes before making links
Previously, when formatting commit messages, anything
that looked like SHA1 hashes was turned into a link
using regex. This meant that certain phrases or numbers
such as `777777` or `deadbeef` could be recognized as a commit
even if the repository has no commit with those hashes.
This change will make it so that anything that looks
like a SHA1 hash using regex will then also be checked
to ensure that there is a commit in the repository
with that hash before making a link.
Signed-off-by: Gary Kim <[email protected]>
* Use gogit to check if commit exists
This commit modifies the commit hash check
in the render for commit messages to use
gogit for better performance.
Signed-off-by: Gary Kim <[email protected]>
* Make code cleaner
Signed-off-by: Gary Kim <[email protected]>
* Use rev-parse to check if commit exists
Signed-off-by: Gary Kim <[email protected]>
* Add and modify tests for checking hashes in html link rendering
Signed-off-by: Gary Kim <[email protected]>
* Return error in sha1CurrentPatternProcessor
Co-Authored-By: mrsdizzie <[email protected]>
* Import Gitea log module
Signed-off-by: Gary Kim <[email protected]>
* Revert "Return error in sha1CurrentPatternProcessor"
This reverts commit 28f561cac4.
Signed-off-by: Gary Kim <[email protected]>
* Add debug logging to sha1CurrentPatternProcessor
This will log errors by the git command run in
sha1CurrentPatternProcessor if the error is one
that was unexpected.
Signed-off-by: Gary Kim <[email protected]>
If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to
the test code, you'll notice that only Errors' Messages are being
compared:
--- PASS: Test_ValidURLValidation/Invalid_schema (0.00s)
binding_test.go:43: [Url] [Url]
FieldNames and Classification are ignored in comparison.
Moreover, an Errors slice with a single Error with empty message
is formatted as '[]' (the same as empty slice), which is also
error-prone. I discovered this when working on #7791 when one test which
was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG
This commit changes the test to do the comparison properly.
David SvantessonandAntoine GIRARD
leigh capiliandAntoine GIRARD
GiteaBot
Tamal Sahaandtechknowlogick
John OlheiserandLunny Xiao
Gary Kimandzeripath
Mura Liandtechknowlogick
Mario LubenkaandLauris BH
guillep2kandzeripath
NorwinandLauris BH
Lanre Adelowoandtechknowlogick
clavinetandtechknowlogick
WGHandLunny Xiao