1
0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00

Merge pull request #872 from octodns/more-cname-tests

Test that CNAME does not allow url and fqdn w/path
This commit is contained in:
Ross McFarland
2022-02-04 14:43:45 -08:00
committed by GitHub

View File

@@ -2281,6 +2281,26 @@ class TestRecordValidation(TestCase):
self.assertEqual(['CNAME value "foo.bar.com" missing trailing .'],
ctx.exception.reasons)
# doesn't allow urls
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, 'www', {
'type': 'CNAME',
'ttl': 600,
'value': 'https://google.com',
})
self.assertEqual(['CNAME value "https://google.com" is not a valid '
'FQDN'], ctx.exception.reasons)
# doesn't allow paths
with self.assertRaises(ValidationError) as ctx:
Record.new(self.zone, 'www', {
'type': 'CNAME',
'ttl': 600,
'value': 'google.com/some/path',
})
self.assertEqual(['CNAME value "google.com/some/path" is not a valid '
'FQDN'], ctx.exception.reasons)
def test_DNAME(self):
# A valid DNAME record.
Record.new(self.zone, 'sub', {