mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

AxfrSource and ZoneFileSource: support multi-value PTR records

Browse Source
This commit is contained in:
Adam Smith
2022-07-22 12:50:24 -04:00
parent a0841f4420
commit 2a56d9b26e
3 changed files with 35 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
octodns/source/axfr.py
View File

@@ -59,6 +59,7 @@ class AxfrBaseSource(BaseSource):
_data_for_A = _data_for_multiple
_data_for_AAAA = _data_for_multiple
_data_for_NS = _data_for_multiple
_data_for_PTR = _data_for_multiple
def _data_for_CAA(self, _type, records):
values = []
@@ -122,7 +123,6 @@ class AxfrBaseSource(BaseSource):
return {'ttl': record['ttl'], 'type': _type, 'value': record['value']}
_data_for_CNAME = _data_for_single
_data_for_PTR = _data_for_single
def _data_for_SRV(self, _type, records):
values = []

17
tests/test_octodns_source_axfr.py
View File

@@ -34,8 +34,14 @@ class TestAxfrSource(TestCase):
'./tests/zones/unit.tests.tst', 'unit.tests', relativize=False
)
reverse_zonefile = dns.zone.from_file(
'./tests/zones/2.0.192.in-addr.arpa.',
'2.0.192.in-addr.arpa',
relativize=False,
)
@patch('dns.zone.from_xfr')
def test_populate(self, from_xfr_mock):
def test_populate_forward(self, from_xfr_mock):
got = Zone('unit.tests.', [])
from_xfr_mock.side_effect = [self.forward_zonefile, DNSException]
@@ -48,6 +54,15 @@ class TestAxfrSource(TestCase):
self.source.populate(zone)
self.assertEqual('Unable to Perform Zone Transfer', str(ctx.exception))
@patch('dns.zone.from_xfr')
def test_populate_reverse(self, from_xfr_mock):
got = Zone('2.0.192.in-addr.arpa.', [])
from_xfr_mock.side_effect = [self.reverse_zonefile]
self.source.populate(got)
self.assertEqual(4, len(got.records))
class TestZoneFileSource(TestCase):
source = ZoneFileSource('test', './tests/zones', file_extension='.tst')

18
tests/zones/2.0.192.in-addr.arpa. Normal file
View File

@@ -0,0 +1,18 @@
$ORIGIN 2.0.192.in-addr.arpa.
@ 3600 IN SOA ns1.unit.tests. root.unit.tests. (
2018071501 ; Serial
3600 ; Refresh (1 hour)
600 ; Retry (10 minutes)
604800 ; Expire (1 week)
3600 ; NXDOMAIN ttl (1 hour)
)
; NS Records
@ 3600 IN NS ns1.unit.tests.
@ 3600 IN NS ns2.unit.tests.
; PTR Records
1 IN PTR foo-1.unit.tests.
2 IN PTR foo-2.unit.tests.
3 IN PTR foo-3.unit.tests.
3 IN PTR foo-4.unit.tests.