mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Normalize ip addresses for comparing health checks since Route53 does

Browse Source
This commit is contained in:
Ross McFarland
2019-04-03 13:10:19 -07:00
parent af06dbec09
commit 34744b7b34
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
octodns/provider/route53.py
View File

@@ -934,11 +934,23 @@ class Route53Provider(BaseProvider):
def _health_check_equivilent(self, host, path, protocol, port,
measure_latency, health_check, value=None):
config = health_check['HealthCheckConfig']
# So interestingly Route53 normalizes IPAddress which will cause us to
# fail to find see things as equivalent. To work around this we'll
# ip_address's returned object for equivalence
# E.g 2001:4860:4860::8842 -> 2001:4860:4860:0:0:0:0:8842
if value:
value = ip_address(unicode(value))
config_ip_address = ip_address(unicode(config['IPAddress']))
else:
# No value so give this a None to match value's
config_ip_address = None
return host == config['FullyQualifiedDomainName'] and \
path == config['ResourcePath'] and protocol == config['Type'] \
and port == config['Port'] and \
measure_latency == config['MeasureLatency'] and \
(value is None or value == config['IPAddress'])
value == config_ip_address
def get_health_check_id(self, record, value, create):
# fqdn & the first value are special, we use them to match up health