mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Cleaner and more compact NS1 record cache management

Browse Source
This commit is contained in:
Viranch Mehta
2021-08-24 00:19:53 -07:00
parent c9fc8feae2
commit 3754c16774
1 changed files with 23 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
octodns/provider/ns1.py
+23 -24
View File
@@ -90,34 +90,37 @@ class Ns1Client(object):
self._zones_cache = {}
self._records_cache = {}
def reset_record_cache(self, zone, domain, _type):
try:
# remove record's zone from cache
del self._zones_cache[zone]
except KeyError:
# never mind if zone is not found in cache
pass
try:
# remove record from cache
del self._records_cache[zone][domain][_type]
except KeyError:
# never mind if record is not found in cache
pass
def update_record_cache(func):
def call(self, zone, domain, _type, **params):
self.reset_record_cache(zone, domain, _type)
if zone in self._zones_cache:
# remove record's zone from cache
del self._zones_cache[zone]
cached = self._records_cache.setdefault(zone, {}) \
.setdefault(domain, {})
new_record = func(self, zone, domain, _type, **params)
if new_record:
cached = self._records_cache.setdefault(zone, {}) \
.setdefault(domain, {})
# record is created/updated
cached[_type] = new_record
elif _type in cached:
# record is deleted
del cached[_type]
return new_record
return call
def read_or_set_record_cache(func):
def call(self, zone, domain, _type):
cached = self._records_cache.setdefault(zone, {}) \
.setdefault(domain, {})
if _type not in cached:
cached[_type] = func(self, zone, domain, _type)
return cached[_type]
return call
@property
def datasource_id(self):
if self._datasource_id is None:
@@ -232,13 +235,9 @@ class Ns1Client(object):
def records_delete(self, zone, domain, _type):
return self._try(self._records.delete, zone, domain, _type)
@read_or_set_record_cache
def records_retrieve(self, zone, domain, _type):
cached = self._records_cache.setdefault(zone, {}) \
.setdefault(domain, {})
if _type not in cached:
cached[_type] = self._try(self._records.retrieve, zone, domain,
_type)
return cached[_type]
return self._try(self._records.retrieve, zone, domain, _type)
@update_record_cache
def records_update(self, zone, domain, _type, **params):