mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Merge pull request #411 from josvo/fix_ns1_create_zone

Browse Source 
Fix 'server error: zone not found' for NS1 provider
This commit is contained in:
Ross McFarland
2019-10-09 07:51:42 -07:00
committed by GitHub
parent ab1164492e 7c34247e3b
commit bb0dcee149
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@@ -182,7 +182,7 @@ The above command pulled the existing data out of Route53 and placed the results
| [EtcHostsProvider](/octodns/provider/etc_hosts.py) | | A, AAAA, ALIAS, CNAME | No | |
| [GoogleCloudProvider](/octodns/provider/googlecloud.py) | google-cloud-dns | A, AAAA, CAA, CNAME, MX, NAPTR, NS, PTR, SPF, SRV, TXT | No | |
| [MythicBeastsProvider](/octodns/provider/mythicbeasts.py) | Mythic Beasts | A, AAAA, ALIAS, CNAME, MX, NS, SRV, SSHFP, CAA, TXT | No | |
| [Ns1Provider](/octodns/provider/ns1.py) | nsone | All | Partial Geo | No health checking for GeoDNS |
| [Ns1Provider](/octodns/provider/ns1.py) | ns1-python | All | Partial Geo | No health checking for GeoDNS |
| [OVH](/octodns/provider/ovh.py) | ovh | A, AAAA, CNAME, MX, NAPTR, NS, PTR, SPF, SRV, SSHFP, TXT, DKIM | No | |
| [PowerDnsProvider](/octodns/provider/powerdns.py) | | All | No | |
| [Rackspace](/octodns/provider/rackspace.py) | | A, AAAA, ALIAS, CNAME, MX, NS, PTR, SPF, TXT | No | |

6
octodns/provider/ns1.py
View File

@@ -8,8 +8,8 @@ from __future__ import absolute_import, division, print_function, \
from logging import getLogger
from itertools import chain
from collections import OrderedDict, defaultdict
from nsone import NSONE
from nsone.rest.errors import RateLimitException, ResourceException
from ns1 import NS1
from ns1.rest.errors import RateLimitException, ResourceException
from incf.countryutils import transformations
from time import sleep
@@ -36,7 +36,7 @@ class Ns1Provider(BaseProvider):
self.log = getLogger('Ns1Provider[{}]'.format(id))
self.log.debug('__init__: id=%s, api_key=***', id)
super(Ns1Provider, self).__init__(id, *args, **kwargs)
self._client = NSONE(apiKey=api_key)
self._client = NS1(apiKey=api_key)
def _data_for_A(self, _type, record):
# record meta (which would include geo information is only

2
requirements.txt
View File

@@ -15,7 +15,7 @@ ipaddress==1.0.22
jmespath==0.9.3
msrestazure==0.6.0
natsort==5.5.0
nsone==0.9.100
ns1-python==0.12.0
ovh==0.4.8
python-dateutil==2.6.1
requests==2.22.0

8
tests/test_octodns_provider_ns1.py
View File

@@ -6,7 +6,7 @@ from __future__ import absolute_import, division, print_function, \
unicode_literals
from mock import Mock, call, patch
from nsone.rest.errors import AuthException, RateLimitException, \
from ns1.rest.errors import AuthException, RateLimitException, \
ResourceException
from unittest import TestCase
@@ -171,7 +171,7 @@ class TestNs1Provider(TestCase):
'domain': 'unit.tests.',
}]
@patch('nsone.NSONE.loadZone')
@patch('ns1.NS1.loadZone')
def test_populate(self, load_mock):
provider = Ns1Provider('test', 'api-key')
@@ -290,8 +290,8 @@ class TestNs1Provider(TestCase):
self.assertEquals(self.expected, zone.records)
self.assertEquals(('unit.tests',), load_mock.call_args[0])
@patch('nsone.NSONE.createZone')
@patch('nsone.NSONE.loadZone')
@patch('ns1.NS1.createZone')
@patch('ns1.NS1.loadZone')
def test_sync(self, load_mock, create_mock):
provider = Ns1Provider('test', 'api-key')