mirror/github-octodns
1
0
Fork 0
mirror of https://github.com/github/octodns.git synced 2024-05-11 05:55:00 +00:00
Code Issues Releases Activity

Merge pull request #388 from willblackie/route53-split-fix

Browse Source 
fix Route53Provider to tollerate multiple separators in record values
This commit is contained in:
Ross McFarland
2019-08-19 06:10:12 -07:00
committed by GitHub
parent 9bb3e48ac2 dd4238ad6b
commit e05f70fb47
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
octodns/provider/route53.py
+4 -4
View File
@@ -723,7 +723,7 @@ class Route53Provider(BaseProvider):
def _data_for_CAA(self, rrset):
values = []
for rr in rrset['ResourceRecords']:
flags, tag, value = rr['Value'].split(' ')
flags, tag, value = rr['Value'].split()
values.append({
'flags': flags,
'tag': tag,
@@ -761,7 +761,7 @@ class Route53Provider(BaseProvider):
def _data_for_MX(self, rrset):
values = []
for rr in rrset['ResourceRecords']:
preference, exchange = rr['Value'].split(' ')
preference, exchange = rr['Value'].split()
values.append({
'preference': preference,
'exchange': exchange,
@@ -776,7 +776,7 @@ class Route53Provider(BaseProvider):
values = []
for rr in rrset['ResourceRecords']:
order, preference, flags, service, regexp, replacement = \
rr['Value'].split(' ')
rr['Value'].split()
flags = flags[1:-1]
service = service[1:-1]
regexp = regexp[1:-1]
@@ -804,7 +804,7 @@ class Route53Provider(BaseProvider):
def _data_for_SRV(self, rrset):
values = []
for rr in rrset['ResourceRecords']:
priority, weight, port, target = rr['Value'].split(' ')
priority, weight, port, target = rr['Value'].split()
values.append({
'priority': priority,
'weight': weight,
tests/test_octodns_provider_route53.py
+1 -1
View File
@@ -503,7 +503,7 @@ class TestRoute53Provider(TestCase):
'ResourceRecords': [{
'Value': '10 smtp-1.unit.tests.',
}, {
'Value': '20 smtp-2.unit.tests.',
'Value': '20 smtp-2.unit.tests.',
}],
'TTL': 64,
}, {