Added support for OS detection from NXOS and UCS (#11722)

* Added support for OS detection from NXOS and UCS

* Changed to SysObjectID instead of Hardware

* Move to YAML

* Rename test cases from nxos to ucos

* Update ucos_2.json

* Rename nxos.yaml to ucos.yaml

Co-authored-by: Tony Murray <[email protected]>

includes/definitions/nxos.yaml

@@ -34,3 +34,7 @@ discovery:
         sysDescr:
             - NX-OS(tm)
             - Cisco NX-OS
+        sysDescr_except:
+            - Cisco NX-OS(tm) ucs # exclude UCS, and indentify as "UCOS" OS
+        sysObjectID_except:
+            - .1.3.6.1.4.1.9.12.3.1.3.1062 # exclude UCS, and indentify as "UCOS" OS

includes/definitions/ucos.yaml

@@ -29,6 +29,8 @@ discovery:
     -
         sysObjectID:
             - .1.3.6.1.4.1.9.1.1348
+            - .1.3.6.1.4.1.9.12.3.1.3.1062
     -
         sysDescr:
             - 'Software:UCOS'
+            - 'Cisco NX-OS(tm) ucs'

tests/data/ucos_2.json

@@ -10,15 +10,32 @@
                     "version": null,
                     "hardware": null,
                     "features": null,
-                    "os": "nxos",
-                    "type": "network",
+                    "os": "ucos",
+                    "type": "collaboration",
                     "serial": null,
                     "icon": "cisco.svg",
                     "location": null
                 }
             ]
         },
-        "poller": "matches discovery"
+        "poller": {
+            "devices": [
+                {
+                    "sysName": "",
+                    "sysObjectID": ".1.3.6.1.4.1.9.12.3.1.3.1062",
+                    "sysDescr": "Cisco NX-OS(tm) ucs, Software (ucs-6100-k9-system), Version 5.0(3)N2(3.13b), RELEASE SOFTWARE Copyright (c) 2002-2013 by Cisco Systems, Inc.   Compiled 6/28/2017 0:00:00",
+                    "sysContact": null,
+                    "version": null,
+                    "hardware": "ciscoModules.3.1.3.1062",
+                    "features": null,
+                    "os": "ucos",
+                    "type": "collaboration",
+                    "serial": null,
+                    "icon": "cisco.svg",
+                    "location": null
+                }
+            ]
+        }
     },
     "sensors": {
         "discovery": {