mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update renamehost include more logging (#15280)

Browse Source 
Added logging output to renamehost() if an RRD Folder already exists for the new hostname.
Before: NOT renamed: Renaming of 10.4.0.146 failed
Now: NOT renamed: Renaming of 10.4.0.146 failed due to existing RRD folder forDEVICE
This commit is contained in:
jaannnis
2023-11-02 06:09:59 +01:00
committed by GitHub
parent 691f64a90e
commit 28e817b7e9
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
includes/functions.php
View File

@@ -108,8 +108,15 @@ function getImageName($device, $use_database = true, $dir = 'images/os/')
function renamehost($id, $new, $source = 'console')
{
$host = gethostbyid($id);
$new_rrd_dir = Rrd::dirFromHost($new);
if (! is_dir(Rrd::dirFromHost($new)) && rename(Rrd::dirFromHost($host), Rrd::dirFromHost($new)) === true) {
if (is_dir($new_rrd_dir)) {
log_event("Renaming of $host failed due to existing RRD folder for $new", $id, 'system', 5);
return "Renaming of $host failed due to existing RRD folder for $new\n";
}
if (! is_dir($new_rrd_dir) && rename(Rrd::dirFromHost($host), $new_rrd_dir) === true) {
dbUpdate(['hostname' => $new, 'ip' => null], 'devices', 'device_id=?', [$id]);
log_event("Hostname changed -> $new ($source)", $id, 'system', 3);