mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix location for devices with broken snmp (#12544)

Browse Source 
AirOS devices with old firmware did not return SNMP results as they should.  This compromise should minimize extra snmp queries.  (Although there are more)
This commit is contained in:
Tony Murray
2021-02-19 11:37:36 -06:00
committed by GitHub
parent d20e1bdf5d
commit 2ab6f63f31
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
LibreNMS/OS/Traits/YamlOSDiscovery.php
View File

@@ -83,7 +83,7 @@ trait YamlOSDiscovery
public function fetchLocation(): Location
{
$os_yaml = $this->getDiscovery('os');
$name = $os_yaml['location'] ?? 'SNMPv2-MIB::sysLocation.0';
$name = $os_yaml['location'] ?? null;
$lat = $os_yaml['lat'] ?? null;
$lng = $os_yaml['long'] ?? null;
@@ -94,7 +94,7 @@ trait YamlOSDiscovery
Log::debug('Yaml location data:', $data);
return new Location([
'location' => $this->findFirst($data, $name, $numeric),
'location' => $this->findFirst($data, $name, $numeric) ?? snmp_get($this->getDeviceArray(), 'SNMPv2-MIB::sysLocation.0', '-Oqv'),
'lat' => $this->findFirst($data, $lat, $numeric),
'lng' => $this->findFirst($data, $lng, $numeric),
]);