recognise some new OSes, add an image for dlink, move sysObjectId polling to be global for os detection

git-svn-id: http://www.observium.org/svn/observer/trunk@1345 61d68cd4-352d-0410-923a-c4978735b2b8

addhost.php

@@ -18,17 +18,19 @@ if($argv[1]) {
   if (!$community) $community = $config['community'];
 
   list($hostshort) 	= explode(".", $host);
-  if ( isDomainResolves($argv[1])){
-    if ( isPingable($argv[1])) {
-      if ( mysql_result(mysql_query("SELECT COUNT(*) FROM `devices` WHERE `hostname` = '".mres($host)."'"), 0) == '0' ) {
+  if ( mysql_result(mysql_query("SELECT COUNT(*) FROM `devices` WHERE `hostname` = '".mres($host)."'"), 0) == '0' ) {
+    if ( isDomainResolves($argv[1])){
+      if ( isPingable($argv[1])) {
+       if ( isSNMPable($argv[1], $community, $snmpver, $port)) {
         $snmphost = trim(str_replace("\"", "", shell_exec($config['snmpget'] ." -m SNMPv2-MIB -Oqv -$snmpver -c $community $host:$port sysName.0")));
-        if ($snmphost == "" || $snmphost && ($snmphost == $host || $hostshort = $host)) {
+        if ($snmphost != "" || $snmphost && ($snmphost == $host || $hostshort = $host)) {
           $return = createHost ($host, $community, $snmpver, $port);
 	  if($return) { echo($return . "\n"); } else { echo("Adding $host failed\n"); }
         } else { echo("Given hostname does not match SNMP-read hostname!\n"); }
-      } else { echo("Already got host $host\n"); }
-    } else { echo("Could not ping $host\n"); }
-  } else { echo("Could not resolve $host\n"); }
+       } else { echo("Could not reach $host with SNMP\n"); }
+      } else { echo("Could not ping $host\n"); }
+    } else { echo("Could not resolve $host\n"); }
+  } else { echo("Already got host $host\n"); }
 } else { echo("Add Host Tool\nUsage: ./addhost.php <hostname> [community] [v1|v2c] [port]\n"); }
 
 ?>

includes/functions.php

@@ -99,8 +99,10 @@ function getHostOS($device)
 {
   global $config;
   
-  $sysDescr_cmd = $config['snmpget']." -m SNMPv2-MIB -O qv -" . $device['snmpver'] . " -c " . $device['community'] . " " . $device['hostname'].":".$device['port'] . " sysDescr.0";
-  $sysDescr = str_replace("\"", "", trim(shell_exec($sysDescr_cmd)));
+  $sysDescr    = snmp_get ($device, "sysDescr.0", "-Ovq");
+  $sysObjectId = snmp_get ($device, "sysObjectID.0", "-Ovqn");
+
+
   $dir_handle = @opendir($config['install_dir'] . "/includes/osdiscovery") or die("Unable to open $path");
   while ($file = readdir($dir_handle))
   {

includes/osdiscovery/discover-airport.php

@@ -0,0 +1,9 @@
+<?php
+
+if(!$os) {
+
+  if(strpos($sysDescr, "Apple AirPort") !== FALSE) { $os = "airport"; }
+
+}
+
+?>

includes/osdiscovery/discover-allied.php

@@ -2,7 +2,6 @@
 
 if(!$os) {
 
-  $sysObjectId = shell_exec($config['snmpget'] . " -Ovqn -".$device['snmpver']." -c ". $device['community'] ." ". $device['hostname'].":".$device['port'] ." sysObjectID.0");
   if(strstr($sysObjectId, ".1.3.6.1.4.1.207")) { $os = "allied"; }
 
 }

includes/osdiscovery/discover-dlink.inc.php

@@ -0,0 +1,10 @@
+<?php
+
+if(!$os) {
+
+  if(strpos($sysDescr, "DES-") !== FALSE) { $os = "dlink"; }
+
+}
+
+
+?>

includes/osdiscovery/discover-extremeware.php

@@ -0,0 +1,9 @@
+<?php
+
+if(!$os) {
+
+  if(strstr($sysObjectId, ".1.3.6.1.4.1.1916.2")) { $os = "extremeware"; }
+
+}
+
+?>

includes/osdiscovery/discover-junos.php

@@ -2,7 +2,6 @@
 
 if(!$os) {
 
-  $sysObjectId = shell_exec($config['snmpget'] . " -Ovqn -".$device['snmpver']." -c ". $device['community'] ." ". $device['hostname'].":".$device['port'] ." sysObjectID.0");
   if(strstr($sysObjectId, ".1.3.6.1.4.1.2636")) { $os = "junos"; }
 
 }

includes/osdiscovery/discover-junose.php

@@ -2,7 +2,6 @@
 
 if(!$os) {
 
-  $sysObjectId = shell_exec($config['snmpget'] . " -Ovqn -".$device['snmpver']." -c ". $device['community'] ." ". $device['hostname'].":".$device['port'] ." sysObjectID.0");
   if(strstr($sysObjectId, ".1.3.6.1.4.1.4874")) { $os = "junose"; }
 
 }

includes/osdiscovery/discover-zywall.php

@@ -0,0 +1,10 @@
+<?php
+
+if(!$os) {
+
+  if(strpos($sysDescr, "ZyWALL") !== FALSE) { $os = "zywall"; }
+
+}
+
+
+?>