mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #11870 from murrant/remove-session-validate

Browse Source 
PHP session is no longer required
This commit is contained in:
Tony Murray
2020-06-28 20:56:24 -05:00
committed by GitHub
parent 89cf1d0508 dad79ae69b
commit 3cd240daf4
2 changed files with 2 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
LibreNMS/Validations/Php.php
View File

@@ -26,7 +26,6 @@
namespace LibreNMS\Validations;
use LibreNMS\Config;
use LibreNMS\ValidationResult;
use LibreNMS\Validator;
class Php extends BaseValidation
@@ -44,7 +43,6 @@ class Php extends BaseValidation
public function validate(Validator $validator)
{
$this->checkVersion($validator);
$this->checkSessionDirWritable($validator);
$this->checkExtensions($validator);
$this->checkFunctions($validator);
$this->checkTimezone($validator);
@@ -64,30 +62,9 @@ class Php extends BaseValidation
}
}
private function checkSessionDirWritable(Validator $validator)
{
$path = session_save_path() === '' ? '/tmp' : session_save_path();
if (!is_writable($path)) {
$result = ValidationResult::fail("The session directory ($path) is not writable.");
$group_id = filegroup($path);
if ($group_id !== 0 && check_file_permissions($path, '060')) {
// don't suggest adding users to the root group or a group that doesn't have write permission.
if (function_exists('posix_getgrgid')) {
$group_info = posix_getgrgid($group_id);
$group = $group_info['name'];
$user = $validator->getUsername();
$result->setFix("usermod -a -G $group $user");
}
}
$validator->result($result);
}
}
private function checkExtensions(Validator $validator)
{
$required_modules = ['mysqlnd', 'mbstring', 'pcre', 'curl', 'session', 'xml', 'gd', 'sockets', 'dom'];
$required_modules = ['mysqlnd', 'mbstring', 'pcre', 'curl', 'xml', 'gd', 'sockets', 'dom'];
if (Config::get('distributed_poller')) {
$required_modules[] = 'memcached';

2
app/Checks.php
View File

@@ -165,7 +165,7 @@ class Checks
return ['mysqlnd'];
}
$required_modules = ['mbstring', 'pcre', 'curl', 'session', 'xml', 'gd'];
$required_modules = ['mbstring', 'pcre', 'curl', 'xml', 'gd'];
return array_filter($required_modules, function ($module) {
return !extension_loaded($module);