mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use Number::constrainInteger instead of unsignedToSigned in Cisco NTP poller (#15667)

Browse Source 
* switch to constrainInteger for cisco ntp too
* correct styleci issue
This commit is contained in:
RobJE
2023-12-21 19:15:02 +01:00
committed by GitHub
parent 6bea8cffa6
commit 4469df10f4
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
includes/polling/ntp/cisco.inc.php
View File

@@ -11,6 +11,7 @@
* the source code distribution for details.
*/
use LibreNMS\Enum\IntegerType;
use LibreNMS\RRD\RrdDefinition;
use LibreNMS\Util\Number;
@@ -63,10 +64,10 @@ if (is_array($components) && count($components) > 0) {
// the last 16 bits.
$hexoffset = $cntpPeersVarEntry['1.3.6.1.4.1.9.9.168.1.2.1.1'][23][$array['UID']];
$rrd['offset'] = Number::unsignedAsSigned(hexdec(substr($hexoffset, 0, 5)), 16) + hexdec(substr($hexoffset, -5)) / 65536;
$rrd['offset'] = Number::constrainInteger(hexdec(substr($hexoffset, 0, 5)), IntegerType::int16) + hexdec(substr($hexoffset, -5)) / 65536;
$hexdelay = $cntpPeersVarEntry['1.3.6.1.4.1.9.9.168.1.2.1.1'][24][$array['UID']];
$rrd['delay'] = Number::unsignedAsSigned(hexdec(substr($hexdelay, 0, 5)), 16) + hexdec(substr($hexdelay, -5)) / 65536;
$rrd['delay'] = Number::constrainInteger(hexdec(substr($hexdelay, 0, 5)), IntegerType::int16) + hexdec(substr($hexdelay, -5)) / 65536;
// Cisco NTPUnsignedTimeValue - 16 bits of unsignedint, and 16 bits of unsignedint for fractional
$hexdisp = $cntpPeersVarEntry['1.3.6.1.4.1.9.9.168.1.2.1.1'][25][$array['UID']];