refactor: OS discovery (w - z) (#4549)

includes/discovery/os/firebox.inc.php

@@ -0,0 +1,5 @@
+<?php
+
+if (starts_with($sysDescr, 'WatchGuard Fireware') || starts_with($sysObjectId, '.1.3.6.1.4.1.3097.1.5')) {
+    $os = 'firebox';
+}

includes/discovery/os/waas.inc.php

@@ -10,6 +10,6 @@
  * the source code distribution for details.
  */
 
-if (starts_with('Cisco Wide Area Application Services', $sysDescr)) {
+if (starts_with($sysDescr, 'Cisco Wide Area Application Services')) {
     $os = 'waas';
 }

includes/discovery/os/watchguard.inc.php

@@ -1,5 +0,0 @@
-<?php
-
-if (starts_with('WatchGuard Fireware', $sysDescr) || starts_with('.1.3.6.1.4.1.3097.1.5', $sysObjectId)) {
-    $os = 'firebox';
-}

includes/discovery/os/webpower.inc.php

@@ -1,5 +1,5 @@
 <?php
 
-if (str_contains('.1.3.6.1.4.1.2468.1.2.1', $sysObjectId)) {
+if (str_contains($sysObjectId, '.1.3.6.1.4.1.2468.1.2.1')) {
     $os = 'webpower';
 }

includes/discovery/os/windows.inc.php

@@ -1,6 +1,6 @@
 <?php
 
-if (starts_with('.1.3.6.1.4.1.311.1.1.3', $sysObjectId)) {
+if (starts_with($sysObjectId, '.1.3.6.1.4.1.311.1.1.3')) {
     $os = 'windows';
 }
 

includes/discovery/os/wxgoos.inc.php

@@ -1,6 +1,6 @@
 <?php
 
-if (str_contains('NETOS 6.0', $sysDescr)) {
+if (str_contains($sysDescr, 'NETOS 6.0')) {
     $os = 'wxgoos';
 }
 

includes/discovery/os/zynos.inc.php

@@ -1,5 +1,5 @@
 <?php
 
-if (starts_with('.1.3.6.1.4.1.890', $sysObjectId) && starts_with($sysDescr, array('ES', 'GS'))) {
+if (starts_with($sysObjectId, '.1.3.6.1.4.1.890') && starts_with($sysDescr, array('ES', 'GS'))) {
     $os = 'zynos';
 }

includes/discovery/os/zywall.inc.php

@@ -1,6 +1,6 @@
 <?php
 
-if (starts_with('ZyWALL 2X', $sysDescr)) {
+if (starts_with($sysDescr, 'ZyWALL 2X')) {
     $os = 'zywall';
 }
 

includes/discovery/os/zyxelnwa.inc.php

@@ -1,5 +1,5 @@
 <?php
 
-if (starts_with('NWA-', $sysDescr)) {
+if (starts_with($sysDescr, 'NWA-')) {
     $os = 'zyxelnwa';
 }