mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix services command injection (#13932)

Browse Source 
* fix services command injection

* Clean more variables

* Update services.inc.php

* Update services.inc.php
This commit is contained in:
Tony Murray
2022-04-20 21:32:36 -05:00
committed by GitHub
parent 3d0e095eb7
commit 8b82341cb7
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
includes/services.inc.php
+6 -1
View File
@@ -4,6 +4,7 @@ use App\Models\Device;
use LibreNMS\Alert\AlertRules;
use LibreNMS\Config;
use LibreNMS\RRD\RrdDefinition;
use LibreNMS\Util\Clean;
function get_service_status($device = null)
{
@@ -120,6 +121,10 @@ function poll_service($service)
{
$update = [];
$old_status = $service['service_status'];
$service['service_type'] = Clean::fileName($service['service_type']);
$service['service_ip'] = Clean::fileName($service['service_ip']);
$service['hostname'] = Clean::fileName($service['hostname']);
$service['overwrite_ip'] = Clean::fileName($service['overwrite_ip']);
$check_cmd = '';
// if we have a script for this check, use it.
@@ -130,7 +135,7 @@ function poll_service($service)
// If we do not have a cmd from the check script, build one.
if ($check_cmd == '') {
$check_cmd = Config::get('nagios_plugins') . '/check_' . $service['service_type'] . ' -H ' . ($service['service_ip'] ? $service['service_ip'] : $service['hostname']);
$check_cmd = Config::get('nagios_plugins') . '/check_' . $service['service_type'] . ' -H ' . ($service['service_ip'] ?: $service['hostname']);
$check_cmd .= ' ' . $service['service_param'];
}