mirror/librenms-librenms
1
0
Fork 0
mirror of https://github.com/librenms/librenms.git synced 2024-10-07 16:52:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix static device group updated message (#10841)

Browse Source 
Previous code was not counting devices added/removed properly, so it would always show no changes made (even though they were)
This commit is contained in:
Tony Murray
2019-11-20 08:59:13 +00:00
committed by PipoCanaja
parent 9a8a2723e3
commit 9436c34507
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/DeviceGroupController.php
View File

@ -137,7 +137,11 @@ class DeviceGroupController extends Controller
$devices_updated = false;
if ($deviceGroup->type == 'static') {
// sync device_ids from input
$devices_updated = array_sum($deviceGroup->devices()->sync($request->get('devices', [])));
$updated = $deviceGroup->devices()->sync($request->get('devices', []));
// check for attached/detached/updated
$devices_updated = array_sum(array_map(function ($device_ids) {
return count($device_ids);
}, $updated)) > 0;
} else {
$deviceGroup->rules = json_decode($request->rules);
}