newdevice: Added basic support for Omnitron iConverters (#6336)

* Added basic support for Omnitron iConverters

* Fixed discovery issue & cropped logo

AUTHORS.md

@@ -196,6 +196,7 @@ LibreNMS contributors:
 - Deeps (deepseth)
 - Jari Schäfer <jari.schaefer@gmail.com> (jarischaefer)
 - Jan-Philipp Litza <janphilipp@litza.de> (jplitza)
+- Lorenzo Zafra <zafra@ualberta.ca> (enzozafra)
 
 Observium was written by:
 - Adam Armstrong

includes/definitions/omnitron-iconverter.yaml

@@ -0,0 +1,12 @@
+os: omnitron-iconverter
+text: 'Omnitron iConverter'
+type: management
+icon: omnitron
+mib_dir:
+    - omnitron
+#over:
+    #- { graph: device_current, text: 'Current' }
+    #- { graph: device_voltage, text: 'Voltage' }
+discovery:
+    - sysObjectId:
+        - .1.3.6.1.4.1.7342.5.

includes/polling/os/omnitron-iconverter.inc.php

@@ -0,0 +1,14 @@
+<?php
+
+// SNMPv2-MIB::sysDescr.1 = STRING: "Omnitron iConverter GM4-HPOE 8991T14F v4.5.28 s/n 00711452 - [x]"
+$description = $poll_device['sysDescr'];
+
+preg_match('~Omnitron\siConverter\s(?\'hardware\'.*?)\s(?\'version\'v.*) s\/n~', $description, $matches);
+
+if ($matches['hardware']) {
+    $hardware = $matches['hardware'];
+}
+
+if ($matches['version']) {
+    $version = $matches['version'];
+}

tests/OSDiscoveryTest.php

@@ -1250,6 +1250,11 @@ class DiscoveryTest extends \PHPUnit_Framework_TestCase
         $this->checkOS('okilan');
     }
 
+    public function testOmnitronIConverter()
+    {
+        $this->checkOS('omnitron-iconverter');
+    }
+
     public function testOnefs()
     {
         $this->checkOS('onefs');

tests/snmpsim/omnitron-iconverter.snmprec

@@ -0,0 +1,2 @@
+1.3.6.1.2.1.1.1.0|4|Omnitron iConverter GM4-HPOE 8991T11D v5.2.14 s/n 00827398 - GM4-PoE - x
+1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.7342.5.1